Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[appveyor] Run the test suite on PHP 7.1 #22560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2017

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Apr 27, 2017

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Apr 27, 2017
@nicolas-grekas nicolas-grekas force-pushed the appveyor-71 branch 6 times, most recently from 62c0a5d to 3e4f1c5 Compare April 28, 2017 00:11
@nicolas-grekas
Copy link
Member Author

Strange failure on a previously (missconfigured) build:
https://ci.appveyor.com/project/fabpot/symfony/build/1.0.21534

@ChadSikorra
Copy link
Contributor

FYI, I wrote a Powershell script to automate the install of PHP on AppVeyor (as chocolatey was super buggy/inconsistent for me). I put the script out here:

https://github.com/ChadSikorra/ps-install-php

Example usage here:

https://github.com/ldaptools/ldaptools-bundle/blob/master/appveyor.yml

Feel free to copy the script if you feel like incorporating it. It's not the cleanest Powershell script, but it does the job.

@nicolas-grekas
Copy link
Member Author

now green
@ChadSikorra thanks for the link, but installing php on windows for the purpose of testing here is really easy, so we don't need any other script IMHO.

@nicolas-grekas nicolas-grekas force-pushed the appveyor-71 branch 4 times, most recently from d9ef3d8 to d83a7f1 Compare May 2, 2017 08:40
@nicolas-grekas nicolas-grekas merged commit a537d6c into symfony:2.7 May 2, 2017
nicolas-grekas added a commit that referenced this pull request May 2, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

[appveyor] Run the test suite on PHP 7.1

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

a537d6c [appveyor] Run the test suite on PHP 7.1
@nicolas-grekas nicolas-grekas deleted the appveyor-71 branch May 2, 2017 09:18
@ChadSikorra
Copy link
Contributor

Shouldn't the AppVeyor build essentially mirror the Travis build? I'd think testing such a large code base against the same versions of PHP on Windows as is done on Linux in Travis would be the target?

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented May 2, 2017

Nope, it's not: we use appveyor to test different conditions than on Travis on purpose, in order to exercice the code base in more diverse situations (different extensions loaded + lowest supported version of PHP)

@stof
Copy link
Member

stof commented May 2, 2017

@ChadSikorra Appveyor is not good at running multiple jobs with different PHP versions in parallel (cache is not keyed by PHP version, invalidating the cache for each job). This is why we restricted ourselves to a single job.
And then, running all tests on all PHP versions twice is not really worth it. Especially when you consider that we have limits on concurrent jobs on each platform, and we don't want to have jobs waiting in the queue for days due to the activity on the repo (in the past, when the build was slower, we used to have to wait for hours to have the CI result during active hours due to this quota).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants