[Console] ChoiceQuestion must have choices #22847
Conversation
|
What is the behavior proposed here? If you pass zero choices to a choice question, shouldn't we throw an exception? |
|
Perhaps easier yes. Went for safe, as i wasnt really sure about the default value behavior (without any further options); or a default value being an unknown option. The first (actually the case from the issue) also crashes, the latter is already validated when the question is optional. So 👍 for throwing in the constructor, unless im unaware of any side effects :) but im fine either way. |
|
Updated. |
| @@ -32,6 +32,10 @@ class ChoiceQuestion extends Question | |||
| */ | |||
| public function __construct($question, array $choices, $default = null) | |||
| { | |||
| if (!$choices) { | |||
| throw new \LogicException('Choice question must have at least 1 choice available.'); | |||
There was a problem hiding this comment.
maybe InvalidArgumentException would be a better fit here?
There was a problem hiding this comment.
@SpacePossum I totally agree with u.
There was a problem hiding this comment.
not sure if we really care :) imo. the argument is valid (an array), but it's domain is invalid (empty array). So DomainException actually (imo.) but i thought LogicException is a bit more common in SF :)
Im fine either way.. as long as it's extends from logic i dont mind :)
There was a problem hiding this comment.
changing it now would be BC break ;) anyway we should be good. If it is a domain level exception I would expect it to be thrown on count < 2 as one option does not leave anything to choose from either ;)
|
Thank you @ro0NL. |
This PR was squashed before being merged into the 2.7 branch (closes #22847). Discussion ---------- [Console] ChoiceQuestion must have choices | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22842 | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> <!--  --> Commits ------- 96e307f [Console] ChoiceQuestion must have choices
Uh oh!
There was an error while loading. Please reload this page.