Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpKernel] remove deprecated features #22886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 24, 2017

Q A
Branch? master
Bug fix? /no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.0 milestone May 24, 2017
@xabbuh xabbuh force-pushed the http-kernel-remove-deprecated-features branch from 508ba77 to d7c8037 Compare May 24, 2017 10:22
@xabbuh xabbuh force-pushed the http-kernel-remove-deprecated-features branch from d7c8037 to 4d522d3 Compare May 24, 2017 10:23
@xabbuh xabbuh changed the title [WIP][HttpKernel] remove deprecated features [HttpKernel] remove deprecated features May 24, 2017
@Tobion
Copy link
Contributor

Tobion commented May 26, 2017

👍

@fabpot
Copy link
Member

fabpot commented May 26, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit 4d522d3 into symfony:master May 26, 2017
fabpot added a commit that referenced this pull request May 26, 2017
This PR was merged into the 4.0-dev branch.

Discussion
----------

[HttpKernel] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | /no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

4d522d3 [HttpKernel] remove deprecated features
@xabbuh xabbuh deleted the http-kernel-remove-deprecated-features branch May 26, 2017 14:32
nicolas-grekas added a commit that referenced this pull request Sep 5, 2017
This PR was merged into the 4.0-dev branch.

Discussion
----------

[HttpKernel] Dont register env parameter resource

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

Think this was forgotten in #22886

Not sure about `EnvParametersResource` in the http-kernel component. Core doesnt use it anymore, so we could deprecate it (and while doing so move it to config component to keep the feature if wanted). Kept as is for now.

Commits
-------

36d2a45 [HttpKernel] Dont register env parameter resource
@fabpot fabpot mentioned this pull request Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants