Fix missing abstract key in XmlDumper #22901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
May 25, 2017
xabbuh
approved these changes
May 25, 2017
8b39e95 to
ad81c6e
Compare
|
@xabbuh yea, me either :). I've renamed it! |
Caused mis-reporting of abstract key (always no) in debug:container
ad81c6e to
40f60ec
Compare
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
May 25, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Fix missing abstract key in XmlDumper | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Unless I'm missing something, the abstract key was missing in the XmlDumper. I noticed it when using `debug:container some_abstract_service` and was seeing "no" for abstract. When this merges to 3.3, the `services-abstract.xml` will need to change to this: ```xml <?xml version="1.0" encoding="utf-8"?> <container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> <services> <service id="service_container" class="Symfony\Component\DependencyInjection\ContainerInterface" synthetic="true"/> <service id="foo" class="Foo" abstract="true"/> <service id="Psr\Container\ContainerInterface" alias="service_container" public="false"/> <service id="Symfony\Component\DependencyInjection\ContainerInterface" alias="service_container" public="false"/> </services> </container> ``` Commits ------- 40f60ec Fixing missing abstract attribute in XmlDumper
This was referenced May 29, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless I'm missing something, the abstract key was missing in the XmlDumper. I noticed it when using
debug:container some_abstract_serviceand was seeing "no" for abstract.When this merges to 3.3, the
services-abstract.xmlwill need to change to this: