[Cache] Dont use pipelining with RedisCluster #22924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a16b6c2 to
a75abfd
Compare
a75abfd to
eb93ac9
Compare
xabbuh
approved these changes
May 27, 2017
nicolas-grekas
added a commit
that referenced
this pull request
May 28, 2017
…kas) This PR was merged into the 3.2 branch. Discussion ---------- [Cache] Dont use pipelining with RedisCluster | Q | A | ------------- | --- | Branch? | 3.é | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22922 | License | MIT | Doc PR | - phpredis doesn't support pipelining with RedisCluster see https://github.com/phpredis/phpredis/blob/develop/cluster.markdown#pipelining and multiple operations (MSET/MGET) work but only "per-shard". We have to fetch keys one by one for now at least. Commits ------- eb93ac9 [Cache] Dont use pipelining with RedisCluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpredis doesn't support pipelining with RedisCluster
see https://github.com/phpredis/phpredis/blob/develop/cluster.markdown#pipelining
and multiple operations (MSET/MGET) work but only "per-shard".
We have to fetch keys one by one for now at least.