-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Profiler] Fix text selection & click on file links on exception pages #22968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pelease dont merge this yet. Thanks. |
Sorry about my last comment, but I wasn't at the computer and I couldn't explain myself. The reason I disabled the selection is that when you click the trace header to collapse/expand it, random parts of it are selected by the browser: Is there any way to enable selecting text but disabling that undesired random selection? Thanks! |
You don't need to apologize! Can someone else try on his side? |
Oh, but re-considering your gif, that's indeed because you're toggling it quite fast, so it's considered a double-click by the browser. |
OK ... and have you tried collapsing/expanding each line of the trace? Because I remember having issues with that too: the entire line was selected and looked ugly. In any case, 👍 from me if you have reviewed this and it works as expected. |
I've just tried. Nothing to report. Maybe the issues you're talking about were more prominent and annoying in a first version of the redesigned page, but now the result is really satisfying to me :) |
Yes, but I thought the error reported in #22971 was fixed and merged in another PR. It was the first thing some people notice with the redesign and there was a PR for that. I can't find it now. |
Thank you @ogizanagi. |
…eption pages (ogizanagi) This PR was squashed before being merged into the 3.3 branch (closes #22968). Discussion ---------- [Profiler] Fix text selection & click on file links on exception pages | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #22957, #22978 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A I don't really know the purpose of this css rule here, but I admit it's quite frustrating not to be able to select something here. This PR also prevents the following annoying behavior (selecting text collapses/uncollapses traces):  About the trick used, I think the browser support is safe enough: https://caniuse.com/#search=window.getSelection EDIT: new commit added which allows to fix #22978 Commits ------- 8618399 [Profiler] Fix clicking on links inside toggle ff6151b [Profiler] Fix text selection on exception pages
I don't really know the purpose of this css rule here, but I admit it's quite frustrating not to be able to select something here.
This PR also prevents the following annoying behavior (selecting text collapses/uncollapses traces):

About the trick used, I think the browser support is safe enough: https://caniuse.com/#search=window.getSelection
EDIT: new commit added which allows to fix #22978