[DependencyInjection] Use more clear message when unused environment variables detected #22976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shound't this be for 3.2? |
…variables detected
|
@nicolas-grekas, I've changed the branch to 3.2 |
| @@ -18,8 +18,8 @@ | |||
| */ | |||
| class EnvParameterException extends InvalidArgumentException | |||
| { | |||
| public function __construct(array $usedEnvs, \Exception $previous = null) | |||
| public function __construct(array $envs, $message, \Exception $previous = null) | |||
There was a problem hiding this comment.
in order to not break BC, the $message arg should be added last, and should be optional ($message = 'Incompatible...')
There was a problem hiding this comment.
@nicolas-grekas, You're right. Fixed.
|
Thank you @voronkovich. |
fabpot
added a commit
that referenced
this pull request
Jun 3, 2017
…nvironment variables detected (voronkovich) This PR was squashed before being merged into the 3.2 branch (closes #22976). Discussion ---------- [DependencyInjection] Use more clear message when unused environment variables detected | Q | A | ------------- | --- | Branch? |3.2 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22955 | License | MIT Old error message: ``` Incompatible use of dynamic environment variables "DATABASE_URL", "MAILER_URL" found in parameters. ``` New error message: ``` Environment variables "DATABASE_URL", "MAILER_URL" are never used. Please, check your container's configuration. ``` Commits ------- 6dbdb1b [DependencyInjection] Use more clear message when unused environment variables detected
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old error message:
New error message: