[Config] Allow empty globs #22985
Merged
[Config] Allow empty globs #22985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
referenced
this pull request
May 31, 2017
* 3.3: [Config] Fallback to regular import when glob fails
6b9e51c to
a07d549
Compare
a07d549 to
c5b9c1a
Compare
|
How would this look like for |
|
you can run the code to know ;) |
fabpot
approved these changes
May 31, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
May 31, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [Config] Allow empty globs | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22950 | License | MIT | Doc PR | - This considers globs as valid even if they return no matches when they have a prefix (and when that prefix exists, according to `$ignoreErrors`). This means there is an edge-case: `*.abc` with at least one match is OK, but when it has no match, it falls back to regular import, then usually will fil. But rewriting this to `./*.abc` resolves the ambiguity and turns this into a glob that won't fail if no matches are found. This should provide the expected behavior in most cases (but ambiguous described one of course). Commits ------- c5b9c1a [Config] Allow empty globs
|
@nicolas-grekas Thanks, this definitely makes more sense for Flex-based apps (using glob patterns). 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This considers globs as valid even if they return no matches when they have a prefix (and when that prefix exists, according to
$ignoreErrors).This means there is an edge-case:
*.abcwith at least one match is OK, but when it has no match, it falls back to regular import, then usually will fil.But rewriting this to
./*.abcresolves the ambiguity and turns this into a glob that won't fail if no matches are found.This should provide the expected behavior in most cases (but ambiguous described one of course).