[Config] Always protected ClassExistenceResource against bad parents #23041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to symfony/recipes#91 (missing parent should not make the container compilation fail) |
fabpot
approved these changes
Jun 2, 2017
d2d2aab to
2041777
Compare
2041777 to
86bf26c
Compare
|
Appveyor failure is from a transient test. |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 2, 2017
…ad parents (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [Config] Always protected ClassExistenceResource against bad parents | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | (new hidden feat) | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Let's always protected against bad or missing parents. The protection was conditional because the protection adds some perf overhead, but this was a micro optim really... BC break is for a new feat, better not maintain this. Commits ------- 86bf26c [Config] Always protect ClassExistenceResource against bad parents
Merged
fabpot
added a commit
that referenced
this pull request
Jul 19, 2017
…nts (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [Config] Make ClassExistenceResource throw on invalid parents | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23564 | License | MIT | Doc PR | - Let's throw a more specific exception when a parent class/interface/trait is missing. Fine tunes #23041 Commits ------- 53b0190 [Config] Make ClassExistenceResource throw on invalid parents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's always protected against bad or missing parents. The protection was conditional because the protection adds some perf overhead, but this was a micro optim really...
BC break is for a new feat, better not maintain this.