[TwigBundle] Add Content-Type header for exception response #23052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we have the same issue on 2.7 and 2.8? If yes, then could you rebase this PR on 2.7? Thanks. |
|
@fabpot yep my bad, done. |
fabpot
approved these changes
Jun 15, 2017
|
Thank you @rchoquet. |
fabpot
added a commit
that referenced
this pull request
Jun 16, 2017
…e (rchoquet) This PR was merged into the 2.7 branch. Discussion ---------- [TwigBundle] Add Content-Type header for exception response | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR comes after I was looking to customize the way exceptions are served for a JSON API (grabbed the info at http://symfony.com/doc/current/controller/error_pages.html#overriding-the-default-exceptioncontroller). I noticed that even when changing the request format to 'json' so that the right json.twig template is served: ```php // in my override of the ExceptionController public function showAction(Request $request, FlattenException $exception, DebugLoggerInterface $logger = null) { $request->setRequestFormat('json'); return parent::showAction($request, $exception, $logger); } ``` the response Content-Type header was still 'text/html'. By now, the response Content-Type should be corresponding to the given request format. I also feel there's some room for improvement with the general "displaying error for a JSON API" chapter as it feels strange that there's no configuration option to just say "serve me anything as json", but that's another issue. Commits ------- 9e2b408 add content-type header on exception response
This was referenced Jul 3, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes after I was looking to customize the way exceptions are served for a JSON API (grabbed the info at http://symfony.com/doc/current/controller/error_pages.html#overriding-the-default-exceptioncontroller).
I noticed that even when changing the request format to 'json' so that the right json.twig template is served:
the response Content-Type header was still 'text/html'.
By now, the response Content-Type should be corresponding to the given request format.
I also feel there's some room for improvement with the general "displaying error for a JSON API" chapter as it feels strange that there's no configuration option to just say "serve me anything as json", but that's another issue.