[Cache] Fix extensibility of TagAwareAdapter::TAGS_PREFIX #23063
Conversation
It seems that when MemcachedAdapter is used with TagAwareAdapter, it fails to fetch items, even though I thoroughly tested fetching items with the exact same keys under the same namespace. Turns out the issue lies in `const TAGS_PREFIX = "\0tags\0";` for unknown to me reasons. Hardcoding that to '__tags__' in my project did the trick and I've been using it for a couple of days now and it seems fine. The reason I had to completely copy/paste this file in my local project is self:: instead of static:: usage. I am not sure whether that is a mistake or is done on purpose, but in order to have this work for me I need to be able to override that constant. Going with static:: seems like a good solution to me, then I can set whatever prefix I need for the tags.
|
You are not supposed to change the value of this const, that's why self:: is used. |
|
As a side note, you should know that with its LRU mechanism, Memcached is not suited for storing tags. |
|
Thank you for your quick response. I'll give As for LRU, the project will run with obscenely high amount of memory on a separate Memcached instance for a critical subset of the data it caches. Besides, there's always the option to give Redis a go. |
|
Thank you @wucdbm. |
…(wucdbm) This PR was submitted for the 3.3 branch but it was merged into the 3.2 branch instead (closes #23063). Discussion ---------- [Cache] Fix extensibility of TagAwareAdapter::TAGS_PREFIX | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | It seems that when MemcachedAdapter is used with TagAwareAdapter, it fails to fetch items, even though I thoroughly tested fetching items with the exact same keys under the same namespace. Edit: Just to clarify, `CacheItem::isHit()` always returned `false`. This is what I meant with the above. Turns out the issue lies in `const TAGS_PREFIX = "\0tags\0";` for unknown to me reasons. Hardcoding that to `'__tags__'` in my project did the trick and I've been using it for a couple of days now and it seems fine. The reason I had to completely copy/paste this file in my local project is `self::` instead of `static::` usage. I am not sure whether that is a mistake or is done on purpose, but in order to have this work for me I need to be able to override that constant. Going with static:: seems like a good solution to me, then I can set whatever prefix I need for the tags. PS: Not exactly sure what to do with tests. Any help would be appreciated. Commits ------- 405f64b [Cache] MemcachedAdapter not working with TagAwareAdapter
|
Merged into branch 3.2, congrats for your first PR :) |
It seems that when MemcachedAdapter is used with TagAwareAdapter, it fails to fetch items, even though I thoroughly tested fetching items with the exact same keys under the same namespace.
Edit: Just to clarify,
CacheItem::isHit()always returnedfalse. This is what I meant with the above.Turns out the issue lies in
const TAGS_PREFIX = "\0tags\0";for unknown to me reasons. Hardcoding that to'__tags__'in my project did the trick and I've been using it for a couple of days now and it seems fine.The reason I had to completely copy/paste this file in my local project is
self::instead ofstatic::usage. I am not sure whether that is a mistake or is done on purpose, but in order to have this work for me I need to be able to override that constant. Going with static:: seems like a good solution to me, then I can set whatever prefix I need for the tags.PS: Not exactly sure what to do with tests. Any help would be appreciated.