[Cache] ApcuAdapter::isSupported() should return true when apc.enable_cli=Off #23091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a62c2a1 to
8ef97d2
Compare
nicolas-grekas
commented
Jun 8, 2017
| @@ -118,7 +118,7 @@ protected function doSave(array $values, $lifetime) | |||
| $ok = $this->write($file, '<?php return '.var_export($data, true).';') && $ok; | |||
|
|
|||
| if ($allowCompile) { | |||
| @opcache_compile_file($file); | |||
| @opcache_invalidate($file, true); | |||
There was a problem hiding this comment.
Just verified with @jpauli: opcache_compile_file does not invalidate. Let's call only opcache_invalidate.
8ef97d2 to
aadf263
Compare
nicolas-grekas
commented
Jun 8, 2017
| @@ -69,7 +69,7 @@ protected function doHave($id) | |||
| */ | |||
| protected function doClear($namespace) | |||
| { | |||
| return isset($namespace[0]) && class_exists('APCuIterator', false) | |||
| return isset($namespace[0]) && class_exists('APCuIterator', false) && ('cli' !== PHP_SAPI || ini_get('apc.enable_cli')) | |||
There was a problem hiding this comment.
new APCuIterator triggers a fatal error when apcu is not enabled...
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 9, 2017
… apc.enable_cli=Off (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [Cache] ApcuAdapter::isSupported() should return true when apc.enable_cli=Off | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - By being sensitive to apc.enable_cli, CLI cache warmup is broken when the setting is set to off because a PhpFilesAdapter will be warmed up by the CLI, whereas the Web mode will look at the FilesystemAdapter pools, which will be empty. Commits ------- aadf263 [Cache] APCu isSupported() should return true when apc.enable_cli=Off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By being sensitive to apc.enable_cli, CLI cache warmup is broken when the setting is set to off because a PhpFilesAdapter will be warmed up by the CLI, whereas the Web mode will look at the FilesystemAdapter pools, which will be empty.