[EventDispatcher] Remove dead code in WrappedListener #23117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jun 9, 2017
| @@ -57,10 +54,6 @@ public function __construct($listener, $name, Stopwatch $stopwatch, EventDispatc | |||
| if (null !== $name) { | |||
| $this->name = $name; | |||
| } | |||
|
|
|||
| if (null === self::$cloner) { | |||
| self::$cloner = class_exists(ClassStub::class) ? new VarCloner() : false; | |||
There was a problem hiding this comment.
I'd keep a static prop for caching the class_exists check, eg:
self::$hasClassStub = class_exists(ClassStub::class);
fabpot
approved these changes
Jun 9, 2017
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Jun 9, 2017
…halasr) This PR was merged into the 3.3 branch. Discussion ---------- [EventDispatcher] Remove dead code in WrappedListener | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a The static `$cloner` property is unused since ab716c6 Commits ------- 8b7de02 [EventDispatcher] Remove dead code in WrappedListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static
$clonerproperty is unused since ab716c6