Add tests for ResponseCacheStrategy to document some more edge cases #23123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2.7 is a great choice :) |
|
Thank you @mpdude. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2017
…e edge cases (mpdude) This PR was squashed before being merged into the 2.7 branch (closes #23123). Discussion ---------- Add tests for ResponseCacheStrategy to document some more edge cases | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Adds some test cases for possible combinations of master/subrequest responses to better document behaviour in edge cases. Should now cover the entire `ResponseCacheStrategy`. I hope 2.7 is the right target branch because having more tests for all releases should be a good thing:tm:. Commits ------- 69e8463 Add tests for ResponseCacheStrategy to document some more edge cases
This was referenced Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some test cases for possible combinations of master/subrequest responses to better document behaviour in edge cases. Should now cover the entire
ResponseCacheStrategy.I hope 2.7 is the right target branch because having more tests for all releases should be a good thing:tm:.