[PropertyAccess] Fix Usage with anonymous classes #23156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c071743 to
5a5a08b
Compare
|
|
||
| public function testAnonymousClassRead() | ||
| { | ||
| if (PHP_MAJOR_VERSION < 7) { |
There was a problem hiding this comment.
use @requires php 7 annotation instead (same below)
| } | ||
|
|
||
| /** | ||
| * @param $value |
Replace forbidden characters in the the class names of Anonymous Classes in form of "class@anonymous /symfony/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php0x7f3f5f267ad5" Wrapped in eval to avoid PHP parsing errors < 7
5a5a08b to
3f7fd43
Compare
fabpot
approved these changes
Jun 14, 2017
dunglas
approved these changes
Jun 14, 2017
|
Thank you @mablae. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [PropertyAccess] Fix Usage with anonymous classes | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23136 | License | MIT Replace forbidden characters in the the class names of Anonymous Classes in form of "class@anonymous /symfony/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php0x7f3f5f267ad5" Wrapped in eval to avoid PHP parsing errors < 7 and using `rawurlenceode` for perf reasons Thanks @nicolas-grekas for the help and patience. Let me know if anything is missing. Commits ------- 3f7fd43 Fix Usage with anonymous classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace forbidden characters in the the class names of Anonymous Classes in form of
"class@anonymous /symfony/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php0x7f3f5f267ad5"
Wrapped in eval to avoid PHP parsing errors < 7 and using
rawurlenceodefor perf reasonsThanks @nicolas-grekas for the help and patience. Let me know if anything is missing.