[FrameworkBundle] Expose the AbstractController's container to its subclasses #23180
Conversation
There was a problem hiding this comment.
Even if we usually don't encourage protected properties, I'm 👍 here:
extending AbstractController::getSubscribedServices() is a legitimate use case that's really missing in 3.3.
Extending setContainer or using ControllerTrait as an alternative is unsupported because both are internal.
Using service argument injection doesn't fit the really-lazy use case (when eg. you first have some authorization check in an action before using a service.)
We could also add get/has methods. Not sure if that'd be better thought. Hence my vote.
| @@ -35,7 +35,7 @@ | |||
| { | |||
| use ControllerTrait; | |||
|
|
|||
| private $container; | |||
| protected $container; | |||
There was a problem hiding this comment.
Pleas add a docblock comment to help IDE with the type of this.
Useful if an application provides their own base Controller that references items in the container. It also makes it simpler for that base controller to add additional optional dependencies by only overriding getSubscribedServices instead of having to reimplement setContainer and use ControllerTrait.
|
Added the docblock. Adding the get/has methods would also solve my use-case. Am happy to add those too or in place of changing the visibility if desired. Controller does both (protected $container comes via ContainerAwareTrait). Laziness is exactly the use case I'm aiming for. This is what I'm trying to do - my base controller will contain various utility methods, and I don't want the overhead of creating the services used by those utilities until I know I need them. |
|
Thank you @BPScott. |
…r to its subclasses (BPScott) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle] Expose the AbstractController's container to its subclasses | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This is useful if an application provides their own base Controller that references items in the container. It also makes it simpler for that base controller to add additional optional dependencies by only overriding getSubscribedServices instead of having to reimplement setContainer and use ControllerTrait. Commits ------- ee17131 Expose the AbstractController's container to its subclasses
This is useful if an application provides their own base Controller that
references items in the container. It also makes it simpler for that
base controller to add additional optional dependencies by only overriding
getSubscribedServices instead of having to reimplement setContainer and
use ControllerTrait.