[DI] Uncomment code #23244
Merged
[DI] Uncomment code #23244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Jun 21, 2017
| @@ -699,19 +686,8 @@ public function prependExtensionConfig($name, array $config) | |||
| * Set to "true" when you want to use the current ContainerBuilder | |||
| * directly, keep to "false" when the container is dumped instead. | |||
| */ | |||
| public function compile(/*$resolveEnvPlaceholders = false*/) | |||
| public function compile($resolveEnvPlaceholders = false) | |||
There was a problem hiding this comment.
should also have the bool typehint, as it is a new explicit argument in 4.0, as done in other methods
chalasr
approved these changes
Jun 21, 2017
xabbuh
approved these changes
Jun 21, 2017
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Jun 21, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [DI] Uncomment code | Q | A | ------------- | --- | Branch? | master <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A I was about fixing all [other occurrences of commented code and `func_get/num_arg(s)`](https://github.com/symfony/symfony/search?utf8=%E2%9C%93&q=func_num_args&type=) as BC layer usages at once, but the following PRs will already cover it: - HttpFoundation: #22863 - Serializer: #23241 - Process: #22836 - DotEnv: #23242 So it only remains DI ones. Commits ------- 03f33b5 [DI] Uncomment code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was about fixing all other occurrences of commented code and
func_get/num_arg(s)as BC layer usages at once, but the following PRs will already cover it:So it only remains DI ones.