Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Dotenv] parse escaped quotes in unquoted env var values #23342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2017
Merged

[Dotenv] parse escaped quotes in unquoted env var values #23342

merged 1 commit into from
Jul 3, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 30, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.3 milestone Jun 30, 2017
@xabbuh xabbuh added the Dotenv label Jun 30, 2017
chalasr
chalasr approved these changes Jul 1, 2017
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #23306 right?

@xabbuh
Copy link
Member Author

xabbuh commented Jul 1, 2017

Nope, this is just another edge case which I discovered while trying to fix #23306. But fixing #23306 is a bit more complex and I am not sure if I will find a good fix for it soon (or before someone else manages to do so). That's why I decided to open a PR with this patch.

@fabpot
Copy link
Member

fabpot commented Jul 3, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit 66a4fd7 into symfony:3.3 Jul 3, 2017
fabpot added a commit that referenced this pull request Jul 3, 2017
@fabpot
bug #23342 [Dotenv] parse escaped quotes in unquoted env var values (…
bfd4173 
…xabbuh)

This PR was merged into the 3.3 branch.

Discussion
----------

[Dotenv] parse escaped quotes in unquoted env var values

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

66a4fd7 parse escaped quotes in unquoted env var values
@xabbuh xabbuh mentioned this pull request Jul 3, 2017
Closed
@xabbuh xabbuh deleted the dotenv-unquoted-escaped-quotes branch July 3, 2017 07:08
@fabpot fabpot mentioned this pull request Jul 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Dotenv Status: Reviewed
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @fabpot @javiereguiluz @chalasr @carsonbot