[Dotenv] parse concatenated variable values #23351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 3, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23306 |
| License | MIT |
| Doc PR |
|
The diff is best viewed at https://github.com/symfony/symfony/pull/23351/files?w=1. |
fabpot
reviewed
Jul 3, 2017
| while ("\n" !== $this->data[$this->cursor] && ')' !== $this->data[$this->cursor]) { | ||
| $value .= $this->data[$this->cursor]; | ||
|
|
||
| if ('(' === $this->data[$this->cursor]) { |
There was a problem hiding this comment.
Looks like we don't have test for that, do we?
There was a problem hiding this comment.
https://github.com/xabbuh/symfony/blob/aaaf64ddde2aa22cb90a1c60fd902865589f5b18/src/Symfony/Component/Dotenv/Tests/DotenvTest.php#L144 and the line below trigger this part
There was a problem hiding this comment.
But we could indeed add a test with non-matching parentheses.
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [Dotenv] parse concatenated variable values | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23306 | License | MIT | Doc PR | Commits ------- aaaf64d [Dotenv] parse concatenated variable values
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.