Add some missing changelog/upgrade infos #23392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
Jul 4, 2017
xabbuh
reviewed
Jul 4, 2017
| @@ -23,6 +23,7 @@ CHANGELOG | |||
| the parser and dumper is no longer supported, pass bitmask flags instead | |||
| * the constructor arguments of the `Parser` class have been removed | |||
| * the `Inline` class is internal and no longer part of the BC promise | |||
| * removed of the support for the `!str` tag, use the `!!str` tag instead | |||
There was a problem hiding this comment.
removed support for the !str tag, use the !!str tag instead
xabbuh
reviewed
Jul 4, 2017
| @@ -14,6 +14,7 @@ CHANGELOG | |||
| methods of the `Process` class have been removed | |||
| * support for passing `proc_open()` options has been removed | |||
| * removed the `ProcessBuilder` class, use the `Process` class instead | |||
| * removed the `getEnhanceWindowsCompatibility()` and `setEnhanceWindowsCompatibility()` methods of `Process` class | |||
xabbuh
reviewed
Jul 4, 2017
| @@ -23,6 +23,7 @@ CHANGELOG | |||
| the parser and dumper is no longer supported, pass bitmask flags instead | |||
| * the constructor arguments of the `Parser` class have been removed | |||
| * the `Inline` class is internal and no longer part of the BC promise | |||
| * removed support for the !str tag, use the !!str tag instead | |||
There was a problem hiding this comment.
I would still enclose the tags with backticks. My comment was meant to point out the missing article.
There was a problem hiding this comment.
Bad previous copy/past... It's fixed.
xabbuh
reviewed
Jul 4, 2017
UPGRADE-4.0.md
Outdated
| @@ -438,6 +438,8 @@ Process | |||
|
|
|||
| * Extending `Process::run()`, `Process::mustRun()` and `Process::restart()` is | |||
| not supported anymore. | |||
|
|
|||
| * The `getEnhanceWindowsCompatibility()` and `setEnhanceWindowsCompatibility()` methods of `Process` class have been removed. | |||
xabbuh
approved these changes
Jul 4, 2017
fabpot
approved these changes
Jul 5, 2017
|
Thank you @maidmaid. |
fabpot
added a commit
that referenced
this pull request
Jul 5, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- Add some missing changelog/upgrade infos | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23387 #23376 #23363 | License | MIT | Doc PR | / Oops, some PRs have been merged without changelog/upgrade infos... Commits ------- 19c6a6f Add some meta infos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops, some PRs have been merged without changelog/upgrade infos...