Debug event dispatcher non objects #234
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not just objects Event subject is defined as mixed, but the Debug Event Dispatcher calls get_class() on the subject, expecting it to be an object. This patch checks for both arrays and objects and updates the information for the profiler accordingly. This change is compatible with PR 221 as long as it is applied beforehand.
|
I'm closing this pull request as it was decided to remove the current implementation and replace it with a new one. |
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Mar 30, 2020
Shopware Security Update 06/2017
chalasr
pushed a commit
to chalasr/symfony
that referenced
this pull request
Sep 24, 2020
add Gitlab CI Integration example
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Debug EventDispatcher only handles null or objects. This allows it to work with the mixed that is defined in the api