[Cache] Added test for ApcuAdapter when using in CLI #23446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
Jul 9, 2017
| $pool->save($item->set('bar')); | ||
| $this->assertFalse($isCalled); | ||
| } finally { | ||
| $prev = set_error_handler($prev); |
There was a problem hiding this comment.
restore_error_handler and you don't need $prev at all
|
Thank you @lyrixx. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 11, 2017
…rixx) This PR was merged into the 3.2 branch. Discussion ---------- [Cache] Added test for ApcuAdapter when using in CLI | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23344 | License | MIT | Doc PR | - --- I also hit #23344 and I did not notice it was already fixed (#23390) and released (2 days ago, I updated the vendors 4 days ago). But as I have written test for it ... Let's contribute anyway Commits ------- 64d196a [Cache] Added test for ApcuAdapter when using in CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also hit #23344 and I did not notice it was already fixed (#23390) and released (2 days ago, I updated the vendors 4 days ago
). But as I have written test for it ... Let's contribute anyway