[Process] Fixed issue between process builder and exec #23498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Jul 13, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes/ |
| Fixed tickets | #23495 |
| License | MIT |
| Doc PR | - |
| @@ -272,6 +272,9 @@ public function getProcess() | |||
|
|
|||
| $arguments = array_merge($this->prefix, $this->arguments); | |||
| $process = new Process($arguments, $this->cwd, $this->env, $this->input, $this->timeout, $this->options); | |||
| // to preserve the BC with symfony <3.3, we convert the array structure | |||
| // to a string structure to avoid the prefixing with the exec binary | |||
There was a problem hiding this comment.
s/command/builtin shell/ ?
nicolas-grekas
approved these changes
Jul 13, 2017
|
Thank you @lyrixx. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 13, 2017
…rixx) This PR was merged into the 3.3 branch. Discussion ---------- [Process] Fixed issue between process builder and exec | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes/ | Fixed tickets | #23495 | License | MIT | Doc PR | - Commits ------- 8cd1a2d [Process] Fixed issue between process builder and exec
fabpot
added a commit
to sensiolabs/SensioGeneratorBundle
that referenced
this pull request
Jul 17, 2017
…avier) This PR was squashed before being merged into the 3.1.x-dev branch (closes #564). Discussion ---------- Fix deprecation notice in test (ProcessBuilder) Backward- and forward-compatible fix for ``` Remaining deprecation notices (1) The Symfony\Component\Process\ProcessBuilder class is deprecated since version 3.4 and will be removed in 4.0. Use the Process class instead: 1x 1x in KernelManipulatorTest::testAddToArray from Sensio\Bundle\GeneratorBundle\Tests\Manipulator ``` Relevant commits: - symfony/process@201c3bd (PR symfony/symfony#23111) - symfony/process@e34416d (PR symfony/symfony#21474) - symfony/process@0743280 (PR symfony/symfony#23498) I also considered the simpler test `\Symfony\Component\HttpKernel\Kernel::VERSION_ID >= 30400` but it seems less reliable (version constant _vs_ code, possibly different versions of `symfony/http-kernel` _vs_ `symfony/process`). Commits ------- 5fe7d3e Fix deprecation notice in test (ProcessBuilder)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.