Deprecated the AdvancedUserInterface #23508

linaori · 2017-07-14T14:18:39Z

Q	A
Branch?	3.4
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	yes
Tests pass?	yes
Fixed tickets	#23292
License	MIT
Doc PR	~

This PR deprecates the usages of the AdvancedUserInterface.

xabbuh · 2017-07-14T14:20:52Z

UPGRADE-3.4.md

+Security
+--------
+
+ * Using the AdvancedUserInterface is now deprecated. To use the existing


AdvancedUserInterface should be enclosed with backticks

xabbuh · 2017-07-14T14:25:36Z

UPGRADE-3.4.md

+--------
+
+ * Using the AdvancedUserInterface is now deprecated. To use the existing
+   functionality, create a custom user-checker based off the


ro0NL · 2017-07-14T17:55:32Z

UPGRADE-3.4.md

+   removed in Symfony 4.0.
+
+ * The in-memory user no longer uses the `AdvancedUserInterface` and has the
+   functionality inlined.


isnt this a BC break?

ro0NL · 2017-07-14T17:57:25Z

UPGRADE-4.0.md

@@ -475,6 +475,14 @@ Security
 * The `AccessDecisionManager::setVoters()` method has been removed. Pass the
   voters to the constructor instead.

+  * Using the AdvancedUserInterface is now deprecated. To use the existing


in 4.0 the AdvancedUserInterface would be removed right?

ro0NL · 2017-07-14T18:01:12Z

src/Symfony/Component/Security/Core/User/AdvancedUserInterface.php

@@ -32,6 +32,7 @@
 *
 * @see UserInterface
 * @see AccountStatusException
+ * @deprecated This interface is deprecated as of 3.4 and will be removed in 4.0.


@deprecated since 3.4, to be removed in 4.0 something like that i believe. Also missing a runtime deprecation? i.e. trigger_error

@deprecated since version 3.4, will be removed in 4.0.
(but no runtime notice because that'd trigger it for existing classes in core)

ro0NL · 2017-07-14T18:04:56Z

src/Symfony/Component/Security/Core/User/UserInterface.php

@@ -47,7 +46,7 @@
     * and populated in any number of different ways when the user object
     * is created.
     *
-     * @return (Role|string)[] The user roles
+     * @return Role|string[] The user roles


Should be reverted, it's intended as PSR-5 doc

Hmm PhpStorm did not recognize this notation and PSR-5 is still not finished

should be Role[]|string[] then I guess?

¯_(ツ)_/¯ technically that's an array of either strings or roles, whereas PSR-5 allows a mixed array.

It should stay (Role|string)[] it's an array that can contains a mix of both Role objects and strings

ro0NL · 2017-07-14T18:06:21Z

src/Symfony/Component/Security/Core/Tests/User/UserCheckerTest.php

+    }
+
+    /**
+     * @group legacy


missing @expectedDeprecation?

ro0NL · 2017-07-15T08:05:25Z

Btw if we deprecate AdvancedUserInterace, i dont see the need to inline those methods into User (as a side effect); we could deprecate those in turn as well. Probably allows to cleanup further :)

greg0ire · 2017-07-15T11:54:20Z

src/Symfony/Component/Security/Core/User/User.php

@@ -18,7 +18,7 @@
 *
 * @author Fabien Potencier <[email protected]>
 */
-final class User implements AdvancedUserInterface
+final class User implements UserInterface, EquatableInterface


Consider this instead;

final class User implements UserInterface, EquatableInterface, AdvancedUserInterface

It should work just fine : https://3v4l.org/eRO4P, and avoids a BC-break for code that does this: $user instanceof AdvancedUserInterface

Yes, that's what I've been thinking off as well after a discussion with @ro0NL on slack. On one side it feels like this behavior shouldn't be used too often, but I also know that if something can happen, it will happen.

I just need to find a way to not trigger a deprecation for that.

I just need to find a way to not trigger a deprecation for that.

In the user checker? I guess you could check the classname before triggering, and if it is the core user class, don't trigger.

Looking at RoleInterface; i think soft deprecating is fine. Implementing EquatableInterface is a new feature really. Perhaps simply revert this line?

linaori · 2017-07-15T16:42:37Z

@ro0NL They are already in the User, so it's merely making them a class only set of functions. I was thinking if we could remove those fields and limit it to a disabled/enabled, but this would influence the messages to the user based on the getMessageKey.

linaori · 2017-07-15T16:43:13Z

Side note, I was thinking of opening an RFC to rename the User to InMemoryUser, as it seems too generic right now. This would also allow cleanup of all those methods.

ro0NL · 2017-07-15T16:46:24Z

I just need to find a way to not trigger a deprecation for that.

rename the User to InMemoryUser

Deprecate User, add InMemoryUser... problem solved?

linaori · 2017-07-15T16:50:18Z

That could make the deprecations of User complete and simply use a smaller InMemory user anyway, Might solve more issues

javiereguiluz · 2017-07-15T17:41:09Z

Please, don't deprecate User by InMemoryUser. It's a really bad name. Remember that Symfony should do the normal simple and the custom possible. The normal is to have a simple user in the database and represent it with a User entity. Thanks!

linaori · 2017-07-15T17:44:02Z

@javiereguiluz the User is the InMemoryUser and should only be used for the in memory provider. Sadly, due to the generic name, this is often mistaken as "the" user class.

javiereguiluz · 2017-07-15T17:51:22Z

@iltar I'm sorry. I should have checked twice before commenting (I was on the phone). If this is the non-persisted user, then InMemoryUser is a perfect name because it's used in other frameworks/technologies too.

nicolas-grekas

some random comments :)

nicolas-grekas · 2017-07-17T07:47:55Z

src/Symfony/Component/Security/Core/Tests/Authentication/Token/AbstractTokenTest.php

@@ -16,6 +16,8 @@
 use Symfony\Component\Security\Core\Role\Role;
 use Symfony\Component\Security\Core\Role\SwitchUserRole;
 use Symfony\Component\Security\Core\User\User;
+use Symfony\Component\Security\Core\User\UserInterface;
+use Symfony\Component\Security\Core\User\AdvancedUserInterface;


alpha order

nicolas-grekas · 2017-07-17T07:48:16Z

src/Symfony/Bridge/Doctrine/Tests/Security/User/EntityUserProviderTest.php

@@ -16,6 +16,7 @@
 use Symfony\Bridge\Doctrine\Tests\Fixtures\User;
 use Symfony\Bridge\Doctrine\Security\User\EntityUserProvider;
 use Doctrine\ORM\Tools\SchemaTool;
+use Symfony\Component\Security\Core\User\UserInterface;


local alpha order: should be moved one line up

nicolas-grekas · 2017-07-17T07:48:59Z

src/Symfony/Bridge/Doctrine/Tests/Security/User/EntityUserProviderTest.php

@@ -156,7 +157,7 @@ public function testLoadUserByUserNameShouldLoadUserWhenProperInterfaceProvided(
            ->method('loadUserByUsername')
            ->with('name')
            ->willReturn(
-                $this->getMockBuilder('\Symfony\Component\Security\Core\User\UserInterface')->getMock()
+                $this->getMockBuilder(UserInterface::class)->getMock()


please revert all the non required ::class, we favor helping future merges than doing these CS updates

nicolas-grekas · 2017-07-17T07:50:54Z

src/Symfony/Component/Security/Core/User/UserInterface.php

@@ -47,7 +46,7 @@
     * and populated in any number of different ways when the user object
     * is created.
     *
-     * @return (Role|string)[] The user roles
+     * @return Role|string[] The user roles


should be Role[]|string[] then I guess?

linaori · 2017-08-04T12:19:56Z

src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php

@@ -264,6 +264,7 @@ private function hasUserChanged(UserInterface $user)
        }

        if ($this->user instanceof AdvancedUserInterface && $user instanceof AdvancedUserInterface) {
+            @trigger_error(sprintf('Checking for the AdvancedUserInterface in %s has been deprecated in 3.4 and will be removed in 4.0. Implement the %s to check if the user has been changed,', __METHOD__, EquatableInterface::class), E_USER_DEPRECATED);


Perhaps I should check for the in memory user class here as well?

it's equatable now.. so it wont get here right?

The User, yes. The custom implementations of the AdvancedUserInterface, no

chalasr · 2017-08-14T08:43:42Z

src/Symfony/Component/Security/Core/Tests/User/UserTest.php

+    public function testIsEqualToWithDifferentUser()
+    {
+        $user = new User('username', 'password');
+        $this->assertFalse($user->isEqualTo($this->createMock(UserInterface::class)));


should be getMockBuilder(UserInterface::class)->getMock() (see travis)

linaori · 2017-08-14T08:57:37Z

@chalasr tests should be green now

ro0NL · 2017-08-15T12:46:13Z

src/Symfony/Component/Security/Core/User/UserChecker.php

@@ -28,10 +28,14 @@ class UserChecker implements UserCheckerInterface
     */
    public function checkPreAuth(UserInterface $user)
    {
-        if (!$user instanceof AdvancedUserInterface) {
+        if (!$user instanceof AdvancedUserInterface && !$user instanceof User) {


why do this? this will break any custom advanced user implem

Previously it would return early if it wasn't an AdvancedUserInterface. In the future, this will be only if it's not a User (InMemoryUser). That's what I meant with the confusion about the naming.

chalasr · 2017-08-23T19:41:35Z

src/Symfony/Component/Security/Core/User/User.php

+            return false;
+        }
+
+        if ($this->isAccountNonExpired() !== $user->isAccountNonExpired()) {


We can't assume that this method exists on $user class since it can be any UserInterface implementation which does not provide it

oops, missed the early return

chalasr

👍 for pushing toward custom user checkers, the community seems to think it's worth dropping this interface.

linaori · 2017-09-25T07:37:18Z

Squashed and rebased against 3.4 to solve merge conflicts

nicolas-grekas · 2017-09-26T14:49:43Z

@iltar sorry another rebase is needed

linaori · 2017-09-27T06:18:38Z

@nicolas-grekas fixed

nicolas-grekas · 2017-09-27T06:24:06Z

src/Symfony/Component/Security/Core/Tests/Authentication/Token/AbstractTokenTest.php

@@ -184,11 +185,9 @@ public function testSetUser($user)

    public function getUsers()
    {
-        $user = $this->getMockBuilder('Symfony\Component\Security\Core\User\UserInterface')->getMock();
-        $advancedUser = $this->getMockBuilder('Symfony\Component\Security\Core\User\AdvancedUserInterface')->getMock();
+        $user = $this->getMockBuilder(UserInterface::class)->getMock();


all the non required "string to ::class" CS changes should be reverted to fit our policy and help reduce future merge conflicts as much as possible

I've changed all usages in my changes to use the strings (in upcoming push). Due to how the diffing works, some of them are not displaying it correctly, as methods have been added/removed. By using the string everywhere, it should be less confusing for git as well.

nicolas-grekas · 2017-09-27T06:24:45Z

src/Symfony/Component/Security/Core/Tests/User/UserCheckerTest.php

+     * @group legacy
+     *
+     * @expectedDeprecation Calling Symfony\Component\Security\Core\User\UserChecker::checkPostAuth with an AdvancedUserInterface is deprecated as of 3.4 and will be removed in 4.0. Create a custom user checker if you wish to keep this functionality.
+     *


extra blank line (same in other places)

nicolas-grekas · 2017-09-27T06:25:39Z

src/Symfony/Component/Security/Core/User/AdvancedUserInterface.php

@@ -32,6 +32,7 @@
 *
 * @see UserInterface
 * @see AccountStatusException
+ * @deprecated This interface is deprecated as of 3.4 and will be removed in 4.0.


@deprecated since version 3.4, will be removed in 4.0.
(but no runtime notice because that'd trigger it for existing classes in core)

xabbuh

except for my minor comments regarding the changelog

xabbuh · 2017-09-27T08:50:49Z

UPGRADE-3.4.md

@@ -277,6 +277,11 @@ Security
   `DigestAuthenticationListener` and `DigestAuthenticationEntryPoint` will be 
   removed in 4.0. Use another authentication system like `http_basic` instead.

+ * Using the `AdvancedUserInterface` is now deprecated. To use the existing
+   functionality, create a custom user-checker based on the
+   `Symfony\Component\Security\Core\UserChecker`. This functionality will be


Symfony\Component\Security\Core\User\UserChecker

This interface will [...]

UserChecker !== UserCheckerInterface

Shouldnt we deprecate UserChecker? as it's tied to AdvancedUserInterface 🤔

No, but imo it should be renamed to the InMemoryUserChecker (see other comments), just like the InMemoryUser. I wish to do this, but I don't have the time to do so before the feature freeze after this gets merged.

If you have time to do so, I'd gladly help out. I'm already stretching my time with non-project related stuff at the moment, so I can't handle another full PR within a few days

I see. But in changelogs shouldnt we promote "based on UserCheckerInterface" instead?

Ill have a look at the InMemory story soonish :) i like it.

@xabbuh This particular reference (and the one for CHANGELOG.md) are correctly referring to the implementation, how the conditions work based on the advanced user interface.

xabbuh · 2017-09-27T08:51:18Z

src/Symfony/Component/Security/CHANGELOG.md

@@ -13,6 +13,10 @@ CHANGELOG
   the user will always be logged out when the user has changed between
   requests.
 * deprecated HTTP digest authentication
+ * Using the AdvancedUserInterface is now deprecated. To use the existing
+   functionality, create a custom user-checker based on the
+   `Symfony\Component\Security\Core\UserChecker`. This functionality will be


Symfony\Component\Security\Core\User\UserChecker

This interface will [...]

nicolas-grekas · 2017-10-02T11:01:04Z

ping @iltar

linaori · 2017-10-02T11:27:09Z

Merge conflicts resolved and namespaces in the md files fixed as comment by xabbuh

nicolas-grekas · 2017-10-24T12:10:54Z

Moving to 4.1 as 3.4 is in beta, thus closed for new feats.

xabbuh · 2017-12-11T07:57:31Z

@iltar Can you rebase and update the changelog/update entries to account for 4.1?

linaori · 2017-12-11T10:09:15Z

@xabbuh should be fixed now

chalasr · 2018-01-18T13:09:57Z

@fabpot still sceptical about this change? It would be good to move forward

nicolas-grekas · 2018-01-21T15:16:45Z

(small rebase needed)

nicolas-grekas · 2018-01-24T19:30:45Z

I'm sorry to come late in the game with this question, but what's the purpose of this change? What's the expected benefit? Every new deprecation has a clear downside: it is asking users to, someday, change their code. That's a cost for sure. What's the other side of the balance that justifies this?

To be honest, I really don't know this part of Symfony, so I don't expect to understand your answer :)
But I'd really like that people who understand what's going on here to still have this reasoning, and that we take the decision on this basis.

Any hints?

linaori · 2018-01-24T20:30:43Z

@nicolas-grekas long story short: this particular part in Symfony is domain logic, rather than infrastructure.

// comes with
public function isAccountNonExpired();
public function isAccountNonLocked();
public function isCredentialsNonExpired();
public function isEnabled();

Those 4 "states" can be reused by an application, but usually does not. In addition to that, the code that everyone uses by default, has all kind of exceptions programmed for the advanced user interface.

The UserChecker doesn't do anything unless it's an advanced user
The AbstractToken (which pretty much every token extends), contains special branches for the AdvancedUserInterface

This kind of logic does (in my opinion), not belong in the core framework. If you don't use the AdvancedUserInterface, Security will still work, but will still contain the domain logic in all the core framework classes.

Symfony by default comes with 1 user class: Symfony\Component\Security\Core\User\User. By default, this user implements the AdvancedUserInterface. However, this user object, is only used for the InMemoryUserProvider. This particular provider (in theory) doesn't need domain logic, because you manage it from the security.yaml config. In any other case, the documentation tells the developer to implement the UserInterface themselves.

So to sum it up:

The AdvancedUserInterface causes the core framework to contain code branches in 2 core classes that is used by pretty much everyone, but never hit
It provides a some form of domain logic with the 4 methods listed above, that are pretty much never needed at all (or maybe subset thereof).
The method names are very confusing due to being negations

As far as I can tell, the AdvancedUserInterface is based on a subset of methods from the Spring user: https://docs.spring.io/spring-security/site/docs/2.0.7.RELEASE/apidocs/org/springframework/security/userdetails/UserDetails.html (much as other parts, like the SecurityContext were based on). I feel that Symfony does not need this by default.

If this PR comes through:

There will be less User related interfaces and branches for a new developer to get confused by
It opens the door to make a NullUserChecker which would become the default, the current user checker doesn't do anything without the interface anyway
It opens the door to add an InMemoryUserChecker, which could do the current checks, if they are still needed (which seems obsolete imo, due to the config being in security.yaml)
It opens the door to rename the current User to InMemoryUser, which is what it's used for

If you have any questions, I'll be happy to answer 👍

nicolas-grekas

(minor rebase needed)

nicolas-grekas · 2018-02-04T19:02:37Z

Thank you @iltar.

This PR was merged into the 4.1-dev branch. Discussion ---------- Deprecated the AdvancedUserInterface | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #23292 | License | MIT | Doc PR | ~ This PR deprecates the usages of the `AdvancedUserInterface`. Commits ------- 8456f3b Deprecated the AdvancedUserInterface

keichinger · 2018-03-01T08:25:42Z

src/Symfony/Component/Security/Core/Tests/Authentication/Token/AbstractTokenTest.php

+     *
+     * @dataProvider getUserChangesAdvancedUser
+     */
+    public function testSetUserSetsAuthenticatedToFalseWhenUserChangesdvancedUser($firstUser, $secondUser)


There's an 'A' missing here to complete the word 'Advanced' :)

Heh, you're completely right! If you wish, you could make a PR to fix this (you can just click the edit file). Gives you a nice contributor tag

Will do =) Thank you.

keichinger · 2018-03-01T08:26:29Z

src/Symfony/Component/Security/Core/Tests/Authentication/Token/AbstractTokenTest.php

@@ -212,53 +209,59 @@ public function testSetUserSetsAuthenticatedToFalseWhenUserChanges($firstUser, $
    }

    public function getUserChanges()
+    {
+        $user = $this->getMockBuilder('Symfony\Component\Security\Core\User\UserInterface')->getMock();


I'm just wondering since I'm not too familiar with the Symfony testing guidelines: Wouldn't it be easier and more refactoring-friendly to use the ::class constants here instead of hand-writing the FQCN?

Consistency in this case. I personally would update everything to use ::class, but that might cause merge conflicts for no reason when merging changes from lower branches upwards.

Fair enough :) Thanks!

Opened #26349

This PR was merged into the 4.1-dev branch. Discussion ---------- Fix typo in test method name | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT This fixes a small typo spotted in #23508 (see https://github.com/symfony/symfony/pull/23508/files/8456f3b32ce6ec394fb27b9fc9a2989ed54862b1#r171488418) Commits ------- e5734aa Fix typo in test method name

hAz4rd0uS · 2018-06-25T21:53:21Z

Hi, what should we use now instead of AdvancedUserInterface ?

chalasr · 2018-06-25T21:56:55Z

@h4ck3rm1k3 https://symfony.com/doc/current/security/user_checkers.html
Please consider reading the "fixed ticket" section of the PR body, discussion happened there :)

* Migrated SF AdvancedUserInterface to FOS UserInterface AdvancedUserInterface is deprecated since Symfony 4.1 - symfony/symfony#23508 Issue: - #2803 Deprecation with Symfony 4.1 - AdvancedUserInterface * Code style fixed and using `getMockBuilder` instead of `createMock` * Code style fixed and using attributes instead of `$this->expectException` * Change to restart travis * EquatableInterface added to `UserInterface` and implementation added to `User` * Tests after merge of master fixed * Tests after merge of master fixed * Update README.md * Added compatibility for apps that check against AdvancedUserInterface * Code style fixed to pass all travis tests * fos_user.user_checker Service marked as non-public

carsonbot added Status: Needs Review Deprecation labels Jul 14, 2017

xabbuh reviewed Jul 14, 2017

View reviewed changes

ro0NL reviewed Jul 14, 2017

View reviewed changes

greg0ire reviewed Jul 15, 2017

View reviewed changes

nicolas-grekas added this to the 3.4 milestone Jul 17, 2017

nicolas-grekas reviewed Jul 17, 2017

View reviewed changes

linaori commented Aug 4, 2017

View reviewed changes

chalasr reviewed Aug 14, 2017

View reviewed changes

ro0NL reviewed Aug 15, 2017

View reviewed changes

sstok mentioned this pull request Aug 16, 2017

[Security] User enabled status is checked before authentication #13994

Closed

chalasr reviewed Aug 23, 2017

View reviewed changes

chalasr approved these changes Aug 23, 2017

View reviewed changes

nicolas-grekas reviewed Sep 27, 2017

View reviewed changes

xabbuh approved these changes Sep 27, 2017

View reviewed changes

nicolas-grekas added the Ready label Oct 2, 2017

nicolas-grekas modified the milestones: 3.4, 4.1 Oct 24, 2017

linaori changed the base branch from 3.4 to master December 11, 2017 09:38

aschempp mentioned this pull request Dec 20, 2017

[WIP] Security changes (step 3) contao/core-bundle#1256

Closed

7 tasks

nicolas-grekas approved these changes Feb 4, 2018

View reviewed changes

Deprecated the AdvancedUserInterface

8456f3b

nicolas-grekas merged commit 8456f3b into symfony:master Feb 4, 2018

linaori mentioned this pull request Feb 13, 2018

Mark 4.1 AdvancedUserInterface deprecated and show alternatives symfony/symfony-docs#9251

Closed

linaori mentioned this pull request Mar 1, 2018

[RFC][Security] Deprecate AdvancedUserInterface #23292

Closed

keichinger reviewed Mar 1, 2018

View reviewed changes

linaori mentioned this pull request Mar 1, 2018

[RFC][Security] Simplify the User and UserChecker #26348

Closed

keichinger mentioned this pull request Mar 1, 2018

Fix typo in test method name #26349

Merged

fabpot mentioned this pull request May 7, 2018

Release v4.1.0-BETA1 #27181

Merged

CarlSchwan mentioned this pull request Jun 10, 2018

Deprecation with Symfony 4.1 - AdvancedUserInterface FriendsOfSymfony/FOSUserBundle#2803

Closed

devtronic mentioned this pull request Jul 7, 2018

Migrated SF AdvancedUserInterface to FOS UserInterface FriendsOfSymfony/FOSUserBundle#2815

Merged

linaori deleted the deprecation/advanced-user-interface branch February 8, 2019 13:37

Deprecated the AdvancedUserInterface #23508

Deprecated the AdvancedUserInterface #23508

Conversation

linaori commented Jul 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ro0NL Jul 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ro0NL commented Jul 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

linaori commented Jul 15, 2017

linaori commented Jul 15, 2017

ro0NL commented Jul 15, 2017 • edited Loading

linaori commented Jul 15, 2017

javiereguiluz commented Jul 15, 2017

linaori commented Jul 15, 2017

javiereguiluz commented Jul 15, 2017

nicolas-grekas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

linaori commented Aug 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chalasr Aug 23, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chalasr left a comment • edited Loading

Choose a reason for hiding this comment

linaori commented Sep 25, 2017

nicolas-grekas commented Sep 26, 2017

linaori commented Sep 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xabbuh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolas-grekas commented Oct 2, 2017

linaori commented Oct 2, 2017

nicolas-grekas commented Oct 24, 2017

xabbuh commented Dec 11, 2017

linaori commented Dec 11, 2017

chalasr commented Jan 18, 2018

nicolas-grekas commented Jan 21, 2018

nicolas-grekas commented Jan 24, 2018 • edited Loading

linaori commented Jan 24, 2018 • edited Loading

nicolas-grekas left a comment

Choose a reason for hiding this comment

nicolas-grekas commented Feb 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ro0NL Jul 17, 2017 •

edited

Loading

ro0NL commented Jul 15, 2017 •

edited

Loading

chalasr Aug 23, 2017 •

edited

Loading

chalasr left a comment •

edited

Loading

nicolas-grekas commented Jan 24, 2018 •

edited

Loading

linaori commented Jan 24, 2018 •

edited

Loading

keichinger Mar 1, 2018 •

edited

Loading