[Profiler] Fix data collector getCasters() call #23516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jul 15, 2017
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 15, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [Profiler] Fix data collector getCasters() call | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Relates to #23465. Calling `DataCollector::getCasters()` using self results into overridden methods in child classes never been called. Also removes an unused property. Commits ------- 34e7094 [Profiler] Fix data collector getCasters() call
fabpot
added a commit
that referenced
this pull request
Jul 17, 2017
…taCollector::getCasters() method (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [Profiler][Validator] ValidatorDataCollector: use new DataCollector::getCasters() method | Q | A | ------------- | --- | Branch? | 3.4 <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #23465 (comment) <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A ~~First commit targets 3.3; see #23516 I didn't re-used the `ConstraintViolationInterface` caster used in the form collector, as it's the purpose of the validator collector to show the constraints data. Commits ------- c725a70 [Profiler][Validator] ValidatorDataCollector: use new DataCollector::getCasters() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #23465. Calling
DataCollector::getCasters()using self results into overridden methods in child classes never been called.Also removes an unused property.