Thanks to visit codestin.com
Credit goes to github.com

Skip to content

- #23650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

- #23650

wants to merge 1 commit into from

Conversation

makasim
Copy link
Contributor

@makasim makasim commented Jul 24, 2017

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jul 25, 2017

I think this does not yet belong to Symfony EventDispatcher:
the queue-interop dependency is not stable (in the sense that it's not yet widely reviewed nor implemented nor used.)
the implementation is totally independent from the current code, which means the code can be released as a standalone library, isn't it?
I'd suggest to do so, and keep up the work on a queue-interop goal for sure!

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jul 25, 2017
@mvrhov
Copy link

mvrhov commented Jul 26, 2017

I beleive @lyrixx is against the proposal as it has a competing implementation in the works.

@sstok
Copy link
Contributor

sstok commented Jul 26, 2017

If this accepted I don't believe it should be part of the EventDispatcher but has it's own Component.

The EventDispatcher Symfony uses is based on the Mediator pattern, where the event can be modified after being dispatched, the Async may not work as one currently excepts from EventDispatcher. In fact, the name EventDispatcher might be wrongfully used for this component 😄

@backbone87
Copy link
Contributor

I would very like such a feature in the core, but have the same opinion as @sstok that it shouldnt be mixed up with the current event dispatcher, but instead should be its own component with specifically optimized interfaces for this purpose.

@nicolas-grekas nicolas-grekas modified the milestones: 3.4, 4.1 Sep 28, 2017
@mkingbe
Copy link

mkingbe commented Oct 13, 2017

what is the status of this feature ?

@Nyholm
Copy link
Member

Nyholm commented Dec 27, 2017

Thank you for this PR.

I agree with Nicholas. The event dispatcher component should not be used for async messages like this. When using async messages you want events to be broadcasted and immutable. That are two fundamental features the event dispatcher does not support by design.

I was down this route a few year ago with https://github.com/fervo/deferred-event-worker

I suggest this PR to be closed.

@lyrixx
Copy link
Member

lyrixx commented Dec 27, 2017

hi.

Thanks for this PR. I also agree with @Nyholm and @nicolas-grekas

We may re-open it later when a nice support of async will land in Symfony. For now, It's a bit too early IMHO.

I suggest this PR to be closed.

@javiereguiluz
Copy link
Member

Let's close this because of the downvotes from the Core Team members .. but we can reconsider it in the future. Thanks!

@makasim makasim deleted the async-event branch December 27, 2017 15:10
@mvrhov
Copy link

mvrhov commented Dec 27, 2017

With the new messaging component #24411 , you'll be able to defer the execution of events.

@makasim makasim changed the title Async event dispatching. - Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants