[DI][ProxyManager] Pass the factory code to execute to DumperInterface::getProxyFactoryCode() #23693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Jul 27, 2017
| @@ -65,19 +65,20 @@ public function isProxyCandidate(Definition $definition) | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function getProxyFactoryCode(Definition $definition, $id, $methodName = null) | |||
| public function getProxyFactoryCode(Definition $definition, $id, $methodCall = null) | |||
There was a problem hiding this comment.
I would name it instantiationExpression instead, as it may not even be a method call.
There was a problem hiding this comment.
updated to $factoryCode
208ddc3 to
a8fce5a
Compare
…e::getProxyFactoryCode()
a8fce5a to
0754617
Compare
fabpot
approved these changes
Jul 28, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 28, 2017
…umperInterface::getProxyFactoryCode() (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI][ProxyManager] Pass the factory code to execute to DumperInterface::getProxyFactoryCode() | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Passing the full code to call the factory is more flexible, as spotted while working on #23678. Commits ------- 0754617 [DI][ProxyManager] Pass the factory code to execute to DumperInterface::getProxyFactoryCode()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the full code to call the factory is more flexible, as spotted while working on #23678.