Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[VarDumper] Do not update source links in a new tab #23780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[VarDumper] Do not update source links in a new tab #23780

wants to merge 4 commits into from

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Aug 3, 2017

Q A
Branch? 3.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

When clicking on a source link in the profiler_dump output we should not open a new tab. My IDE will open automatically and it will just leave an empty tab in my browser.

I could also argue for that we never should open a new tab.

@chalasr
Copy link
Member

chalasr commented Aug 3, 2017

Experienced this too, never opening a new tab seems right to me (just ctrl|cmd+click instead). Tests need to be updated

@Nyholm
Copy link
Member Author

Nyholm commented Aug 3, 2017

Thank you for the review. I've updated the PR and tests are all green now

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Aug 3, 2017 •
edited
Loading

I'm not sure about the experience when no IDE is configured: when you click, you loose the current state, so that the back button might be broken, isn't it?
When you have an IDE, this effectively means you open in another window btw...
I'd prefer an iframe in the current window personally.

@nicolas-grekas
Copy link
Member

What about adding some logic so that ide links don't have the target set?
Note that there are more IDE links than the ones generated by VarDumper.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 5, 2017
@Nyholm
Copy link
Member Author

Nyholm commented Aug 5, 2017

Sure, I'll look into that. Thanks

@ro0NL
Copy link
Contributor

ro0NL commented Aug 6, 2017

For the iframe approach, have a look at #21045 it probably works for dumps as well :)

@nicolas-grekas
Copy link
Member

Closing as this is not the approach comments direct to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Feature Status: Needs Review VarDumper
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@Nyholm @chalasr @nicolas-grekas @ro0NL @javiereguiluz @carsonbot