-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DI] Add PHP service factories #23935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
115 changes: 115 additions & 0 deletions
115
src/Symfony/Component/DependencyInjection/Compiler/ServiceFactoryTagPass.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\DependencyInjection\Compiler; | ||
|
||
use Symfony\Component\DependencyInjection\Container; | ||
use Symfony\Component\DependencyInjection\Definition; | ||
use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException; | ||
use Symfony\Component\DependencyInjection\Reference; | ||
|
||
/** | ||
* Applies the "container.service_factory" tag by scraping class methods used for Definition instances. | ||
* | ||
* @author Roland Franssen <[email protected]> | ||
*/ | ||
final class ServiceFactoryTagPass extends AbstractRecursivePass | ||
{ | ||
/** | ||
* {@inheritdoc} | ||
*/ | ||
protected function processValue($value, $isRoot = false) | ||
{ | ||
if (!$value instanceof Definition || !$value->hasTag('container.service_factory')) { | ||
return parent::processValue($value, $isRoot); | ||
} | ||
|
||
if (!$r = $this->container->getReflectionClass($class = $value->getClass())) { | ||
throw new InvalidArgumentException(sprintf('Class "%s" used for service factory "%s" cannot be found.', $class, $this->currentId)); | ||
} | ||
|
||
if ($r->isAbstract()) { | ||
throw new InvalidArgumentException(sprintf('Class "%s" used for service factory "%s" cannot be abstract.', $class, $this->currentId)); | ||
} | ||
|
||
foreach ($this->getMethodsToFactorize($r) as $id => $method) { | ||
$this->container->register($id) | ||
->setFactory(array(new Reference($this->currentId), $method->getName())) | ||
->setClass($this->getClass($method)); | ||
} | ||
} | ||
|
||
/** | ||
* Gets the list of methods to factorize. | ||
* | ||
* @param \ReflectionClass $reflectionClass | ||
* | ||
* @return \ReflectionMethod[] | ||
*/ | ||
private function getMethodsToFactorize(\ReflectionClass $reflectionClass) | ||
{ | ||
$methodsToFactorize = array(); | ||
|
||
foreach ($reflectionClass->getMethods() as $method) { | ||
if ($method->isConstructor()) { | ||
continue; | ||
} | ||
|
||
while (true) { | ||
if (false !== $doc = $method->getDocComment()) { | ||
if (false !== stripos($doc, '@service') && preg_match('#(?:^/\*\*|\n\s*+\*)\s*+@service(?:\s(\S+)?|\*/$)#i', $doc, $matches)) { | ||
if (!$method->isPublic()) { | ||
throw new InvalidArgumentException(sprintf('Method "%s::%s()" must be public in order to create a service from it.', $reflectionClass->getName(), $name)); | ||
} | ||
|
||
$id = isset($matches[1]) ? $matches[1] : Container::underscore($method->getName()); | ||
if (isset($methodsToFactorize[$id]) || $this->container->has($id)) { | ||
throw new InvalidArgumentException(sprintf('Cannot create service "%s" from service factory "%s" as it already exists.', $id, $this->currentId)); | ||
} | ||
|
||
$methodsToFactorize[$id] = $method; | ||
break; | ||
} | ||
if (false === stripos($doc, '@inheritdoc') || !preg_match('#(?:^/\*\*|\n\s*+\*)\s*+(?:\{@inheritdoc\}|@inheritdoc)(?:\s|\*/$)#i', $doc)) { | ||
break; | ||
} | ||
} | ||
try { | ||
$method = $method->getPrototype(); | ||
} catch (\ReflectionException $e) { | ||
break; // method has no prototype | ||
} | ||
} | ||
} | ||
|
||
return $methodsToFactorize; | ||
} | ||
|
||
private function getClass(\ReflectionMethod $reflectionMethod) | ||
{ | ||
if (method_exists(\ReflectionMethod::class, 'getReturnType')) { | ||
$returnType = $reflectionMethod->getReturnType(); | ||
if (null !== $returnType && !$returnType->isBuiltin()) { | ||
$returnType = $returnType instanceof \ReflectionNamedType ? $returnType->getName() : $returnType; | ||
switch (strtolower($returnType)) { | ||
case 'self': | ||
return $reflectionMethod->getDeclaringClass()->getName(); | ||
case 'parent': | ||
return get_parent_class($reflectionMethod->getDeclaringClass()->getName()) ?: null; | ||
default: | ||
return $returnType; | ||
} | ||
} | ||
} | ||
|
||
return null; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should be able to use
Symfony\Component\DependencyInjection\LazyProxy\ProxyHelper::getTypeHint()
instead