[Debug] Remove false-positive check in DebugClassLoader #23989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we know what kind of edge cases are triggering this ? The exception in case of mistake in the class name or the namespace was actually useful to me. It would be great to know what triggers this edge case |
|
Just found why, I'm going to update the PR asap. |
92a71f3 to
a7a8dae
Compare
a7a8dae to
466da3f
Compare
|
now with a test case |
|
I can confirm it fixes my issue! Thanks! By the way: What is the best/easiest way to test a symfony pr in an existing project, when not using symfony/symfony (because of flex)? |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 27, 2017
…icolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Debug] Remove false-positive check in DebugClassLoader | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23977 | License | MIT | Doc PR | - In some edge case situations, DebugClassLoader generates false-positives (see linked issue, ping @gharlan). Commits ------- 466da3f [Debug] Remove false-positive check in DebugClassLoader
This was referenced Aug 28, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some edge case situations, DebugClassLoader generates false-positives (see linked issue, ping @gharlan).