[HttpKernel] Fix loading legacy 3.3 containers in 3.4 context #24040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Aug 30, 2017
|
Yeah, I had this issue which was gone after clearing the cache. Thanks for fixing. 👍 |
fabpot
approved these changes
Aug 30, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 30, 2017
…ext (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] Fix loading legacy 3.3 containers in 3.4 context | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - When moving from 3.3 to 3.4, if a dumped container exists, an exception is triggered because "include" returns "1". ping @umpirsky Commits ------- 8264a9e [HttpKernel] Fix loading legacy 3.3 containers in 3.4 context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving from 3.3 to 3.4, if a dumped container exists, an exception is triggered because "include" returns "1".
ping @umpirsky