Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated console error font color #24125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

MrSunshyne
Copy link

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

The previous white on red(ANSI) was hard to read.
Black on red is much more pleasant to read.

Before / After comparison

before-after-console-color

The previous white on red(ANSI) was hard to read.

Black on red is much more pleasant to read.
@ro0NL
Copy link
Contributor

ro0NL commented Sep 7, 2017

Looks good here :)

image

But black will do as well... just find it a bit too dark;

image

More or less related to #23393, i.e. we could do black on yellow for warnings then too no?

@linaori
Copy link
Contributor

linaori commented Sep 7, 2017

Probably a setting in your terminal/console that's not set correctly.
image
Seems to be working just fine here as well.

@stof
Copy link
Member

stof commented Sep 7, 2017

Yeah, it all depends on whether the color scheme of the terminal actually displays red in red on in pink. White on red is fine. White on pink is not

@yceruto
Copy link
Member

yceruto commented Sep 7, 2017

@MrSunshyne I faced the same issue in PhpStorm IDE Terminal & Solarized Dark scheme, and I solved it setting ANSI gray foreground to white or black for better contrast (Settings > Editor > Color Scheme > Console Colors).

Native OS terminal looks fine though.

@fabpot
Copy link
Member

fabpot commented Sep 7, 2017

Closing as it has work that way for many years now without any complaints. We cannot tweak the values for all possible themes anyway.

@fabpot fabpot closed this Sep 7, 2017
@MrSunshyne
Copy link
Author

@yceruto I assumed this wasn't tied to the IDE, because I noticed the same unreadable style on different Linux and macOS systems. Hence the PR.

@javiereguiluz
Copy link
Member

An additional problem with this proposal is that black text over color background doens't always work as expected. See this old comment that mentions it. By the way, that's the reason why warnings in Console's Symfony Style have a read background instead of yellow (they were originally black text over yellow background).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants