[PhpUnitBridge] do not require an error context #24192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error context argument of an error handler is deprecated as of PHP 7.2. Requiring it in the error handler of the SymfonyTestsListenerTrait will make error handlers fail that are executed when running PHPUnit tests and forward the error handling to the previously registered error handler.
nicolas-grekas
approved these changes
Sep 19, 2017
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 19, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [PhpUnitBridge] do not require an error context | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The error context argument of an error handler is deprecated as of PHP 7.2. Requiring it in the error handler of the SymfonyTestsListenerTrait will make error handlers fail that are executed when running PHPUnit tests and forward the error handling to the previously registered error handler. Commits ------- 10ce932 [PhpUnitBridge] do not require an error context
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error context argument of an error handler is deprecated as of PHP
7.2. Requiring it in the error handler of the SymfonyTestsListenerTrait
will make error handlers fail that are executed when running PHPUnit
tests and forward the error handling to the previously registered error
handler.