added clean option to assets install command #24216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinlehrmann
commented
Sep 15, 2017
•
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #24204, #23416 |
| License | MIT |
|
Should probably go into 3.4 as it's a new feature, even though I know why it "broke". |
|
I'd propose to reverse the flag, and submit it on 3.4, as a new feature, so that people can opt-out if they want (yes, that'd mean keeping the BC break, I know, let's live with that.) |
xabbuh
reviewed
Nov 26, 2017
| @@ -58,6 +58,7 @@ protected function configure() | |||
| )) | |||
| ->addOption('symlink', null, InputOption::VALUE_NONE, 'Symlinks the assets instead of copying it') | |||
| ->addOption('relative', null, InputOption::VALUE_NONE, 'Make relative symlinks') | |||
| ->addOption('clean', null, InputOption::VALUE_NONE, 'Remove the assets of the bundles that no longer exist') | |||
There was a problem hiding this comment.
@nicolas-grekas suggested the opposite (i.e. having a no-cleanup option or something similar) which would need to be passed if you do not want to have old assets removed.
|
@xabbuh Okay, I changed it. Good point 👍 |
xabbuh
approved these changes
Nov 26, 2017
Tobion
approved these changes
Nov 29, 2017
|
Thank you @robinlehrmann. |
fabpot
added a commit
that referenced
this pull request
Dec 7, 2017
…rmann) This PR was merged into the 4.1-dev branch. Discussion ---------- added clean option to assets install command | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24204, #23416 | License | MIT Commits ------- 771f11b added clean option to assets install command
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.