Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TwigBundle exception/deprecation tweaks #24244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 27, 2017
Merged

TwigBundle exception/deprecation tweaks #24244

merged 4 commits into from
Sep 27, 2017

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Sep 17, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes/no
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...
  • 1st commit) if you view a exception in the profiler, there is no logger available. Making the tab useless, disabled state is now triggered at zero log messages. There's a specialized panel here.
  • 2nd commit) when an exception occurs this highlights deprecations in the log table outside the profiler with a warning status. This follows the same signal colors in the profiler.
  • 3rd commit) hide the default inactive tabs from CSS to avoid scrollbar flickering.
  • 4th commit) favors document.DOMContentLoaded over window.load, we dont want to wait for images to be loaded

Further out-of-scope improvements could be;

@ro0NL ro0NL changed the base branch from 3.4 to 3.3 September 21, 2017 17:24
@ro0NL
Copy link
Contributor Author

ro0NL commented Sep 21, 2017

Ive switched to 3.3, for consistency across branches. Added 2 more commits to improve performance of page with heavy tabs (request+logger panel). The CSS tweak is priceless :) and avoids scrollbar jumping around.

Not sure about 0c10f97 for 3.3, or 3.4. It fixes the signaling IMHO.

@ro0NL ro0NL mentioned this pull request Sep 21, 2017
@fabpot
Copy link
Member

fabpot commented Sep 27, 2017

Thank you @ro0NL.

@fabpot fabpot merged commit 1c595fc into symfony:3.3 Sep 27, 2017
fabpot added a commit that referenced this pull request Sep 27, 2017
This PR was squashed before being merged into the 3.3 branch (closes #24244).

Discussion
----------

TwigBundle exception/deprecation tweaks

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes/no
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

- 1st commit) if you view a exception in the profiler, there is no logger available. Making the tab useless, disabled state is now triggered at zero log messages. There's a specialized panel here.
- 2nd commit) when an exception occurs this highlights deprecations in the log table outside the profiler with a warning status. This follows the same signal colors in the profiler.
- 3rd commit) hide the default inactive tabs from CSS to avoid scrollbar flickering.
- 4th commit) favors document.DOMContentLoaded over window.load, we dont want to wait for images to be loaded

Further out-of-scope improvements could be;

- From #24191; i think the logs table should show a direct `View file` link for every error/deprecation/red or yellow line in here. Traversing with `Show context` is tedious.
  - links to file.php for your trigger_error() calls
  - links to config.yml for trigger_error() calls by SF
- From #24151; having the same tooling on both sides is nice
- Events/Translations logs is noise, we have specialized panels for those. To further reduce the overall page size container logs can be moved away too, linked from Configuration and/or Logs. Also see #23247

Commits
-------

1c595fc [TwigBundle][WebProfilerBundle] Switch to DOMContentLoaded event
ea4b096 [WebProfilerBundle] Hide inactive tabs from CSS
0c10f97 [TwigBundle] Make deprecations scream in logs
03cd9e5 [TwigBundle] Hide logs if unavailable, i.e. webprofiler
@ro0NL ro0NL deleted the tweaks branch September 27, 2017 06:53
@fabpot fabpot mentioned this pull request Oct 5, 2017
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull request Mar 25, 2018
This PR was squashed before being merged into the 3.3 branch (closes symfony#24244).

Discussion
----------

TwigBundle exception/deprecation tweaks

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes/no
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

- 1st commit) if you view a exception in the profiler, there is no logger available. Making the tab useless, disabled state is now triggered at zero log messages. There's a specialized panel here.
- 2nd commit) when an exception occurs this highlights deprecations in the log table outside the profiler with a warning status. This follows the same signal colors in the profiler.
- 3rd commit) hide the default inactive tabs from CSS to avoid scrollbar flickering.
- 4th commit) favors document.DOMContentLoaded over window.load, we dont want to wait for images to be loaded

Further out-of-scope improvements could be;

- From symfony#24191; i think the logs table should show a direct `View file` link for every error/deprecation/red or yellow line in here. Traversing with `Show context` is tedious.
  - links to file.php for your trigger_error() calls
  - links to config.yml for trigger_error() calls by SF
- From symfony#24151; having the same tooling on both sides is nice
- Events/Translations logs is noise, we have specialized panels for those. To further reduce the overall page size container logs can be moved away too, linked from Configuration and/or Logs. Also see symfony#23247

Commits
-------

1c595fc [TwigBundle][WebProfilerBundle] Switch to DOMContentLoaded event
ea4b096 [WebProfilerBundle] Hide inactive tabs from CSS
0c10f97 [TwigBundle] Make deprecations scream in logs
03cd9e5 [TwigBundle] Hide logs if unavailable, i.e. webprofiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants