Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[CS / micro opt] [POC/WP] please ignore for now #24344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

SpacePossum
Copy link
Contributor

please ignore, I just want to see what Travis thinks ;)

@sstok
Copy link
Contributor

sstok commented Sep 27, 2017

Mother of

That's allot of changes 😄 (hope it doesn't cause to much back (s)lash :trollface: )

Jokes aside I'm curious to see what the performance difference is here :)

@SpacePossum
Copy link
Contributor Author

Haha @sstok :D
This fixes only functions known that the PHP compiler optimizes and only those outside the global namespace. Without those two restrictions the diff would look even more insane (but even more performance gain might have gotten) :P
Sadly the tests are failing and there is no setup to test speed performance of a PR.
So, back to drawing board, lets see why I kicked over all the tests services ones again ;)

@sstok
Copy link
Contributor

sstok commented Sep 28, 2017

Failure is properly related, but you should be able to benchmark the performance gain using https://blackfire.io/ I remember @nicolas-grekas already tried to improve performance using this but the improvements were either to low or only made sense at some places 🤔

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Sep 28, 2017

On VarDumper, I already measured a significant perf improvement when using root-namespaces for listed functions only. This does not apply to all functions, only to this specifically optimized list, see
PHP-CS-Fixer/PHP-CS-Fixer#3048

@keradus
Copy link
Member

keradus commented Sep 28, 2017

when applied on PHP CS Fixer, I got about 5.5% boost of fix command (under PHP 7.1.9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants