[Session] remove deprecated session handlers #24447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
commented
Oct 5, 2017
| } | ||
| } | ||
|
|
||
| public function testWriteWhenUsingExpiresField() |
There was a problem hiding this comment.
this test doing the same as the one above. sometime in the past (symfony 2?) the expiry_field option seemed to be optional. but that is not the case anymore
f83c826 to
0a7af3f
Compare
This was referenced Oct 5, 2017
fabpot
approved these changes
Oct 5, 2017
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [Session] remove deprecated session handlers | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | yes | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#8486 Removes deprecated session handler from #24389, #24438 and #24443 Commits ------- 0a7af3f [Session] remove deprecated session handlers
fabpot
added a commit
that referenced
this pull request
Oct 5, 2017
…ssions (Tobion) This PR was merged into the 2.7 branch. Discussion ---------- [Session] fix MongoDb session handler to gc all expired sessions | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | MongoDB session handler `gc` wrongly only deleted one random expired session instead of all of them. Care when merging to master as this will conflict with #24447 Commits ------- e6895bf [Session] fix MongoDb session handler to gc all expired sessions
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 13, 2017
This PR was merged into the master branch. Discussion ---------- Update outdated session documentation with SF 4 The PHP 5.3 compatibilty and proxy logic has been removed in symfony/symfony#24338 The MemcacheSessionHandler is removed with symfony/symfony#24447 Commits ------- bd765c1 Update outdated session documentation with SF 4
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes deprecated session handler from #24389, #24438 and #24443