[DI] minor docblock fixes #24663
Merged
[DI] minor docblock fixes #24663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
reviewed
Oct 22, 2017
| @@ -37,7 +37,7 @@ public function __construct(ServiceReferenceGraphNode $sourceNode, ServiceRefere | |||
| } | |||
|
|
|||
| /** | |||
| * Returns the value of the edge. | |||
| * Returns the mixed of the edge. | |||
64d5609 to
b4917aa
Compare
xabbuh
reviewed
Oct 23, 2017
| * @param string $reference | ||
| */ | ||
| public function connect($sourceId, $sourceValue, $destId, $destValue = null, $reference = null) | ||
| { | ||
| if (null === $sourceId || null === $destId) { |
There was a problem hiding this comment.
Why this change? Just as a safe guard?
There was a problem hiding this comment.
found while adding type hints on master
9835d8a to
186e620
Compare
|
now with more useless docblocks removed |
ro0NL
reviewed
Oct 24, 2017
| protected $result; | ||
| protected $messages = array(); |
ca73949 to
a27c47b
Compare
Now with even more docblocks removed |
a27c47b to
0c9edaf
Compare
|
(failure unrelated) |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 24, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [DI] minor docblock fixes | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As found in #24611 Commits ------- 0c9edaf [DI] minor docblock fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found in #24611