[WebProfilerBundle] add missing tests #24666
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X-Debug-Token was not set, so the test was actually testing what happens when the token is not set. The corresponding line in WebDebugToolbarListener could have been commented out and the test did not break.
The condition for Content-Type was not tested, so it was possible to comment it out without breaking tests.
|
Travis fails only on PHP 5.4 in |
fabpot
approved these changes
Nov 5, 2017
|
Thank you @mhujer. |
fabpot
added a commit
that referenced
this pull request
Nov 5, 2017
This PR was squashed before being merged into the 2.7 branch (closes #24666). Discussion ---------- [WebProfilerBundle] add missing tests | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT This PR fixes one test in WebDebugToolbarListenerTest and adds one that was missing (more detailed description is available in the commits description) Commits ------- 363d3a8 [WebProfilerBundle] add missing tests
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
This PR was squashed before being merged into the 2.7 branch (closes symfony#24666). Discussion ---------- [WebProfilerBundle] add missing tests | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT This PR fixes one test in WebDebugToolbarListenerTest and adds one that was missing (more detailed description is available in the commits description) Commits ------- 363d3a8 [WebProfilerBundle] add missing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes one test in WebDebugToolbarListenerTest and adds one that was missing (more detailed description is available in the commits description)