[ClassLoader] Added a class map file generator utility #2471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| class ClassMapDumper | ||
| { | ||
|
|
|
@TheSalla do you have time/interest to finish this up? |
|
sure (will attempt at least), but no sooner than tomorrow |
|
If you don't have any other suggestions or ideas, I'd consider it finished. |
| // Find the classname | ||
| while (($t = $tokens[++$i]) && is_array($t)) { | ||
| if (T_STRING === $t[0]) { | ||
| $class .= $t[1]; |
There was a problem hiding this comment.
Your class have problems with extending over classes:
'Doctrine\DBAL\Driver\IBMDB2\DB2ConnectionDoctrineDBALDriverConnection' => string 'Z:\home\chat.loc\www\protected\App\Lib\doctrine-orm\Doctrine\DBAL\Driver\IBMDB2\DB2Connection.php'
There was a problem hiding this comment.
Thank you. It is fixed now.
|
ping |
| * | ||
| * @author Gyula Sallai <[email protected]> | ||
| */ | ||
| class ClassMapDumper |
There was a problem hiding this comment.
What about renaming it to just ClassMap as the main feature is the creation of the class map, not the dump part.
There was a problem hiding this comment.
Well, I don't really like the idea, since that class name would suggest this class represents a single class map, instead of a tool of class map creation. I see your point, but it feels wrong to me.
There was a problem hiding this comment.
Sounds good to me.
|
@TheSalla: Can you rename the ClassMapDumper class to ClassMapGenerator and then squash your commit before the merge? Thanks. |
fixed cs Small refactoring for Finder support If class name found, return Find multiple classes and namespaces in the same file fixed problems with inheritance and non-php files Renamed ClassMapDumper to ClassMapGenerator fixed error with splfileinfo
|
@fabpot done. |
fabpot
added a commit
that referenced
this pull request
Feb 6, 2012
Commits ------- ba3b321 [ClassLoader] Added a class map file generator utility Discussion ---------- [ClassLoader] Added a class map file generator utility Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: #2407 --------------------------------------------------------------------------- by lsmith77 at 2011-11-30T19:33:52Z @TheSalla do you have time/interest to finish this up? --------------------------------------------------------------------------- by thesalla at 2011-12-01T09:55:50Z sure (will attempt at least), but no sooner than tomorrow --------------------------------------------------------------------------- by stof at 2011-12-12T20:41:41Z @TheSalla @fabpot what is the state of this PR ? --------------------------------------------------------------------------- by thesalla at 2011-12-17T19:36:58Z If you don't have any other suggestions or ideas, I'd consider it finished. --------------------------------------------------------------------------- by lsmith77 at 2012-01-24T09:27:12Z ping --------------------------------------------------------------------------- by fabpot at 2012-02-02T08:21:38Z @TheSalla: Can you rename the ClassMapDumper class to ClassMapGenerator and then squash your commit before the merge? Thanks. --------------------------------------------------------------------------- by thesalla at 2012-02-04T12:55:48Z @fabpot done.
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 15, 2014
…pGenerator class (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Components][ClassLoader] documentation for the ClassMapGenerator class | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#2471) | Applies to | all | Fixed tickets | #1134 Commits ------- 2ebe6c3 documentation for the ClassMapGenerator class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #2407