[TwigBundle] Added priority to twig extensions #24777
Conversation
| foreach ($container->findTaggedServiceIds('twig.extension', true) as $id => $attributes) { | ||
| $priority = isset($attributes[0]['priority']) ? $attributes[0]['priority'] : 0; | ||
| $prioritizedLoaders[$priority][] = $id; | ||
| } |
There was a problem hiding this comment.
Could this be replaced by using the PriorityTaggedServiceTrait?
|
Can you explain the use case for having priorities on extensions? I do understand the need for loaders, but I fail to see why we would need them for extensions. |
|
@fabpot I was recently working on something and needed to overload a filter - I was lucky in that where I was registering it, it was after the previous one being registered (so as per docs here: https://twig.symfony.com/doc/2.x/advanced.html#overloading) but figured that might not always be the case. |
| foreach ($container->findTaggedServiceIds('twig.extension', true) as $id => $attributes) { | ||
| $definition->addMethodCall('addExtension', array(new Reference($id))); | ||
| foreach ($this->findAndSortTaggedServices('twig.extension', $container) as $extension) { | ||
| $definition->addMethodCall('addExtension', array(new Reference($extension))); |
There was a problem hiding this comment.
$extension is already a reference so that this code could be simplified
| class TwigEnvironmentPassTest extends TestCase | ||
| { | ||
| /** | ||
| * @var \PHPUnit_Framework_MockObject_MockObject |
There was a problem hiding this comment.
for clarity i prefer /** @var Type */ thus inline. But not a blocker :) and im not sure we do that elsewhere anyway.
There was a problem hiding this comment.
AFAIK, we don't do much "inline" on properties.
|
@ro0NL will add a changelog entry now, what version should it go under? |
|
4.0.0 but there's a 4.4.0 entry already, i think it's a typo :) |
|
@ro0NL I'll add a 4.0.0 section, want me to correct the 4.4.0 one to 4.0.0? |
|
think so. affects master only anyway. |
|
@ro0NL - added changelog entry for you |
| ----- | ||
|
|
||
| * removed `ContainerAwareRuntimeLoader` | ||
| * added priority to twig extensions |
There was a problem hiding this comment.
should be added in a new entry for 4.1.0
There was a problem hiding this comment.
@nicolas-grekas done :)
| 4.4.0 | ||
| 4.1.0 | ||
| ----- | ||
| * added priority to twig extensions |
|
|
||
| protected function setUp() | ||
| { | ||
| $this->builder = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->setMethods(array('hasDefinition', 'findTaggedServiceIds', 'setAlias', 'getDefinition'))->getMock(); |
There was a problem hiding this comment.
I would not mock the ContainerBuilder class
There was a problem hiding this comment.
I based it on this test: https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/Compiler/TwigLoaderPassTest.php#L36
I can change it to use the actual builder if you'd like?
| @@ -1,6 +1,10 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| 4.1.0 | |||
| ----- | |||
| * added priority to Twig extensions | |||
There was a problem hiding this comment.
missing blank line before
| */ | ||
| private $pass; | ||
|
|
||
| protected function setUp() |
There was a problem hiding this comment.
we don't need this method IMHO, better remove it and the corresponding properties
Moves the properties on the test class to variables inside the single test method it has.
|
Thank you @Brunty. |
Added priority to twig extensions in the
TwigEnvironmentPassto control the order in which they're registered, similar to theTwigLoaderPassThough, unsure on what priority to use as a default, and will PR docs when finalised.