Micro optim using explicit root namespaces #24866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lets do them all in one go; ^_^ |
fabpot
approved these changes
Nov 7, 2017
dunglas
approved these changes
Nov 7, 2017
Simperfit
approved these changes
Nov 8, 2017
xabbuh
approved these changes
Nov 8, 2017
nicolas-grekas
added a commit
that referenced
this pull request
Nov 8, 2017
This PR was merged into the 3.4 branch. Discussion ---------- Micro optim using explicit root namespaces | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Just doing that makes my local hello world as fast on 3.3 as on 4.0. Spotted using Blackfire to identify the hot path. Confirmed using both `ab` and `blackfire curl` on a local `php -S`. It's not the first time these root namespaces make a measurable difference (on a selected list of functions only, see PHP-CS-Fixer/PHP-CS-Fixer#3048.) PHP-CS-Fixer/PHP-CS-Fixer#3222 might become a more generic fix for this kind of optims. Commits ------- e78d1c4 Micro optim using explicit root namespaces
|
Follow-up proposal on Drupal core: https://www.drupal.org/project/drupal/issues/2960522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just doing that makes my local hello world as fast on 3.3 as on 4.0.
Spotted using Blackfire to identify the hot path.
Confirmed using both
abandblackfire curlon a localphp -S.It's not the first time these root namespaces make a measurable difference (on a selected list of functions only, see PHP-CS-Fixer/PHP-CS-Fixer#3048.)
PHP-CS-Fixer/PHP-CS-Fixer#3222 might become a more generic fix for this kind of optims.