[TwigBridge] Fixed the .form-check-input class in the bs4 templates #24874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the composer.json file of the Twig bridge needs to be updated also, "conflicts" section |
nicolas-grekas
approved these changes
Nov 12, 2017
fabpot
approved these changes
Nov 12, 2017
|
Thank you @vudaltsov. |
fabpot
added a commit
that referenced
this pull request
Nov 12, 2017
…templates (vudaltsov) This PR was squashed before being merged into the 3.4 branch (closes #24874). Discussion ---------- [TwigBridge] Fixed the .form-check-input class in the bs4 templates | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | If I am not mistaken, the `form-check-input` class should always be present in inputs of checkboxes and radios Commits ------- 95a90e4 [TwigBridge] Fixed the .form-check-input class in the bs4 templates
This was referenced Nov 12, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I am not mistaken, the
form-check-inputclass should always be present in inputs of checkboxes and radios