[FrameworkBundle] add a notice when passing a routerInterface without warmupInterface in RouterCacheWarmer #24894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f437cf8 to
66d49f3
Compare
chalasr
reviewed
Nov 10, 2017
| @@ -43,6 +43,8 @@ public function warmUp($cacheDir) | |||
| { | |||
| if ($this->router instanceof WarmableInterface) { | |||
| $this->router->warmUp($cacheDir); | |||
| } else { | |||
| trigger_error(sprintf('%s is not a instanceof %s, no warmUp has been triggered.', get_class($this->router), WarmableInterface::class), \E_USER_NOTICE); | |||
There was a problem hiding this comment.
IMHO we could trigger a deprecation now and throw a LogicException at the end.
There was a problem hiding this comment.
Ddo we ever trigger a notice in the code base? This is suspicious to me :)
There was a problem hiding this comment.
We trigger warning but not notices you are right, I will change that with @chalasr's suggestion
There was a problem hiding this comment.
Since we are triggering a deprecation, we should go with master ?
There was a problem hiding this comment.
Yes, triggering/throwing does not fix a bug, it only enhances DX. This is for master in any case IMO
There was a problem hiding this comment.
Rebase and throw added.
66d49f3 to
6656dbe
Compare
0458373 to
6df98e5
Compare
xabbuh
reviewed
Nov 15, 2017
|
|
||
| return; | ||
| } else { | ||
| @trigger_error(sprintf('Passing a %s without implementing %s is deprecated since 4.1.', RouterInterface::class, WarmableInterface::class), \E_USER_DEPRECATED); |
There was a problem hiding this comment.
I do not understand why we care about a deprecation if we immediately throw afterwards anyway.
There was a problem hiding this comment.
We MUST NOT throw (we cannot do it until 5.0). We should have only the deprecation notice.
stof
requested changes
Nov 17, 2017
|
|
||
| return; | ||
| } else { | ||
| @trigger_error(sprintf('Passing a %s without implementing %s is deprecated since 4.1.', RouterInterface::class, WarmableInterface::class), \E_USER_DEPRECATED); |
There was a problem hiding this comment.
We MUST NOT throw (we cannot do it until 5.0). We should have only the deprecation notice.
6df98e5 to
4128cf8
Compare
|
done @stof |
4128cf8 to
cfd840f
Compare
|
I will update the Changelog |
|
Travis failure seems unrelated |
xabbuh
reviewed
Nov 20, 2017
| @@ -45,6 +45,10 @@ public function warmUp($cacheDir) | |||
|
|
|||
| if ($router instanceof WarmableInterface) { | |||
| $router->warmUp($cacheDir); | |||
|
|
|||
| return; | |||
| } else { | |||
There was a problem hiding this comment.
no need for the else as the previous if returns anyway
cfd840f to
060f65a
Compare
|
Status: Needs Review |
6e94f29 to
18453aa
Compare
xabbuh
reviewed
Dec 7, 2017
UPGRADE-4.1.md
Outdated
| @@ -16,3 +16,8 @@ Translation | |||
|
|
|||
| * The `FileDumper::setBackup()` method is deprecated and will be removed in 5.0. | |||
| * The `TranslationWriter::disableBackup()` method is deprecated and will be removed in 5.0. | |||
|
|
|||
| FrameworkBundle | |||
There was a problem hiding this comment.
Sorry for nitpicking @Simperfit, but could you please move this up sort entries alphabetically (makes searching for something much easier in the future with many more entries)?
18453aa to
06faa74
Compare
xabbuh
approved these changes
Dec 7, 2017
|
Needs rebase |
| } | ||
|
|
||
| @trigger_error(sprintf('Passing a %s without implementing %s is deprecated since 4.1.', RouterInterface::class, WarmableInterface::class), \E_USER_DEPRECATED); |
06faa74 to
879a720
Compare
|
PR rebased |
879a720 to
b5d9048
Compare
…rmupInterface in RouterCacheWarmer
b5d9048 to
daa7f02
Compare
|
PR Rebased |
|
@nicolas-grekas this one is ready. |
fabpot
approved these changes
Jan 26, 2018
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Jan 26, 2018
…terface without warmupInterface in RouterCacheWarmer (Simperfit) This PR was merged into the 4.1-dev branch. Discussion ---------- [FrameworkBundle] add a notice when passing a routerInterface without warmupInterface in RouterCacheWarmer | Q | A | ------------- | --- | Branch? | master | Bug fix? | yesish | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #23403 | License | MIT | Doc PR | none I'm adding a test to RouterCacheWarmer since there were none. Commits ------- daa7f02 [FrameworkBundle] add a notice when passing a routerInterface with warmupInterface in RouterCacheWarmer
Tobion
reviewed
Feb 19, 2018
| FrameworkBundle | ||
| --------------- | ||
|
|
||
| * Using a `RouterInterface` that does not implement the `WarmableInterface` is not supported anymore. |
There was a problem hiding this comment.
This must mention that it is about RouterCacheWarmer. This has nothing to do with the RouterInterface itself.
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Feb 25, 2018
…ions (xabbuh) This PR was merged into the 4.1-dev branch. Discussion ---------- [FrameworkBundle] clarify changelog and upgrade instructions | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#24894 (comment) | License | MIT | Doc PR | Commits ------- a8df0aee92 clarify changelog and upgrade instructions
Tobion
added a commit
that referenced
this pull request
Feb 25, 2018
…ions (xabbuh) This PR was merged into the 4.1-dev branch. Discussion ---------- [FrameworkBundle] clarify changelog and upgrade instructions | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24894 (comment) | License | MIT | Doc PR | Commits ------- a8df0ae clarify changelog and upgrade instructions
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jun 5, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Routing] remove deprecations | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | yes <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | Ref. #30249, #30286, #24894 Commits ------- 5beb5f8 [Routing] remove deprecations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding a test to RouterCacheWarmer since there were none.