[Console] Fixed exit code with non-integer throwable code #24951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For 2.7? Can you add a test case please? |
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
Dec 11, 2017
…(wouterj) This PR was merged into the 4.1-dev branch. Discussion ---------- [Console] Fixed exit code with non-integer throwable code | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The exception/error code in PHP doesn't have to be an integer: > Returns the exception code as integer in Exception but possibly as other type in Exception descendants (for example as string in PDOException). > http://php.net/manual/en/exception.getcode.php#refsect1-exception.getcode-returnvalues This means that a "Return value of Symfony\Component\Console\Event\ConsoleErrorEvent::getExitCode() must be of the type integer, string returned" error is shown when e.g. an uncatched PDOException is handled by the console error event. Commits ------- ca86e65 Fixed exit code with non-integer throwable code
|
merged in master, but cherry-picked in 3.3 as this is a bug fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception/error code in PHP doesn't have to be an integer:
This means that a "Return value of Symfony\Component\Console\Event\ConsoleErrorEvent::getExitCode() must be of the type integer, string returned" error is shown when e.g. an uncatched PDOException is handled by the console error event.