[TwigBundle][FrameworkBundle] Remove the internals from debug autowiring #25011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test don't pass yet :)
|
4991228 to
bc7c0f0
Compare
| <tag name="console.command" command="lint:yaml" /> | ||
| </service> | ||
|
|
||
| <service id="Symfony\Component\Form\Command\DebugCommand"> | ||
| <service id="console.debug_command" class="Symfony\Component\Form\Command\DebugCommand"> |
There was a problem hiding this comment.
suffix "command" here, but not on the other ones, should it be always here?
| @@ -314,7 +313,7 @@ public function testWorkflowServicesCanBeEnabled() | |||
| $container = $this->createContainerFromFile('workflows_enabled'); | |||
|
|
|||
| $this->assertTrue($container->has(Registry::class)); | |||
| $this->assertTrue($container->hasDefinition(WorkflowDumpCommand::class)); | |||
| $this->assertTrue($container->hasDefinition('console.workflow_dump')); | |||
There was a problem hiding this comment.
console.command.workflow_dump? other convention?
There was a problem hiding this comment.
console.command.<underscored_name> 👍
| @@ -112,13 +112,13 @@ | |||
| <argument>%kernel.debug%</argument> | |||
| </service> | |||
|
|
|||
| <service id="Symfony\Bundle\FrameworkBundle\Controller\RedirectController" public="true"> | |||
| <service id="framework.controller.redirect" class="Symfony\Bundle\FrameworkBundle\Controller\RedirectController" public="true"> | |||
There was a problem hiding this comment.
I think we need to keep this and the next one, not for autowiring, but to ease routing
bc7c0f0 to
7aab8a9
Compare
|
The review has been taken into account. |
ro0NL
reviewed
Nov 19, 2017
| <tag name="console.command" command="lint:yaml" /> | ||
| </service> | ||
|
|
||
| <service id="Symfony\Component\Form\Command\DebugCommand"> | ||
| <service id="console.command.debug" class="Symfony\Component\Form\Command\DebugCommand"> |
There was a problem hiding this comment.
console.command.form_debug id say
| @@ -314,7 +313,7 @@ public function testWorkflowServicesCanBeEnabled() | |||
| $container = $this->createContainerFromFile('workflows_enabled'); | |||
|
|
|||
| $this->assertTrue($container->has(Registry::class)); | |||
| $this->assertTrue($container->hasDefinition(WorkflowDumpCommand::class)); | |||
| $this->assertTrue($container->hasDefinition('console.workflow_dump')); | |||
There was a problem hiding this comment.
console.command.<underscored_name> 👍
ro0NL
reviewed
Nov 19, 2017
| @@ -7,13 +7,13 @@ | |||
| <services> | |||
| <defaults public="false" /> | |||
|
|
|||
| <service id="Symfony\Bridge\Twig\Command\DebugCommand"> | |||
| <service id="twig.debug_command" class="Symfony\Bridge\Twig\Command\DebugCommand"> | |||
stof
requested changes
Nov 19, 2017
| @@ -7,101 +7,101 @@ | |||
| <services> | |||
| <defaults public="false" /> | |||
|
|
|||
| <service id="console.error_listener" class="Symfony\Component\Console\EventListener\ErrorListener"> | |||
| <service id="console.command.error_listener" class="Symfony\Component\Console\EventListener\ErrorListener"> | |||
There was a problem hiding this comment.
renamig is not good. This service is not a command
| <tag name="console.command" command="lint:yaml" /> | ||
| </service> | ||
|
|
||
| <service id="Symfony\Component\Form\Command\DebugCommand"> | ||
| <service id="console.command.debug" class="Symfony\Component\Form\Command\DebugCommand"> |
| <argument type="service" id="translation.writer" /> | ||
| <argument type="service" id="translation.reader" /> | ||
| <argument type="service" id="translation.extractor" /> | ||
| <argument>%kernel.default_locale%</argument> | ||
| <tag name="console.command" command="translation:update" /> | ||
| </service> | ||
|
|
||
| <service id="Symfony\Bundle\FrameworkBundle\Command\WorkflowDumpCommand"> | ||
| <service id='console.workflow_dump' class="Symfony\Bundle\FrameworkBundle\Command\WorkflowDumpCommand"> |
| @@ -7,13 +7,13 @@ | |||
| <services> | |||
| <defaults public="false" /> | |||
|
|
|||
| <service id="Symfony\Bridge\Twig\Command\DebugCommand"> | |||
| <service id="twig.debug_command" class="Symfony\Bridge\Twig\Command\DebugCommand"> | |||
@nicolas-grekas if that's what you wonder, AddConsoleCommandPass should process correctly no matter the service id |
7aab8a9 to
ec069ef
Compare
|
done @stof |
dunglas
requested changes
Nov 20, 2017
| <argument type="service" id="translation.writer" /> | ||
| <argument type="service" id="translation.reader" /> | ||
| <argument type="service" id="translation.extractor" /> | ||
| <argument>%kernel.default_locale%</argument> | ||
| <tag name="console.command" command="translation:update" /> | ||
| </service> | ||
|
|
||
| <service id="Symfony\Bundle\FrameworkBundle\Command\WorkflowDumpCommand"> | ||
| <service id='console.command.workflow_dump' class="Symfony\Bundle\FrameworkBundle\Command\WorkflowDumpCommand"> |
ec069ef to
e2ecf05
Compare
e2ecf05 to
491839b
Compare
|
There are two remaining services when testing this with the standard edition:
looking more precisely with @Simperfit, we discovered that these classes are actually registered twice: first with a class as id, second with a regular id. Needs to be understood and fixed. |
nicolas-grekas
approved these changes
Nov 20, 2017
|
Thank you @Simperfit. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2017
…debug autowiring (Simperfit) This PR was merged into the 3.4 branch. Discussion ---------- [TwigBundle][FrameworkBundle] Remove the internals from debug autowiring | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? |no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #24986 | License | MIT | Doc PR | #SymfonyConHackday2017 @nicolas-grekas @weaverryan @fabpot @stof It should be OK to review and to merge. Commits ------- 491839b [TwigBundle][FrameworkBundle] Remove the internals from debug autowiring
nicolas-grekas
added a commit
that referenced
this pull request
Dec 8, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Form] Fix debug:form command definition | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Sadly these changes were forgotten in #25011 and the `debug:form` command does not work properly right now :( Commits ------- 97fdf31 Fix debug:form definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#SymfonyConHackday2017
@nicolas-grekas @weaverryan @fabpot @stof It should be OK to review and to merge.