[Validator] Deprecate validating DateTimeInterface in Date|Time|DateTime constraints #25015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| if ($value instanceof \DateTimeInterface) { | ||
| @trigger_error(sprintf('Validating a \\DateTimeInterface with "%s" is deprecated since version 4.1 and will throw an exception in 5.0. Use "%s" instead.', DateTime::class, Type::class), E_USER_DEPRECATED); |
fabpot
approved these changes
Sep 4, 2018
| } | ||
|
|
||
| if ($value instanceof \DateTimeInterface) { | ||
| @trigger_error(sprintf('Validating a \\DateTimeInterface with "%s" is deprecated since version 4.1 and will throw an exception in 5.0. Use "%s" instead.', DateTime::class, Type::class), E_USER_DEPRECATED); |
| } | ||
|
|
||
| if ($value instanceof \DateTimeInterface) { | ||
| @trigger_error(sprintf('Validating a \\DateTimeInterface with "%s" is deprecated since version 4.1 and will throw an exception in 5.0. Use "%s" instead.', Date::class, Type::class), E_USER_DEPRECATED); |
stof
reviewed
Sep 4, 2018
| } | ||
|
|
||
| if ($value instanceof \DateTimeInterface) { | ||
| @trigger_error(sprintf('Validating a \\DateTimeInterface with "%s" is deprecated since version 4.1 and will throw an exception in 5.0. Use "%s" instead.', DateTime::class, Type::class), E_USER_DEPRECATED); |
There was a problem hiding this comment.
The suggested alternative could also be to remove the constraint if you always have a \DateTimeInterface|null in your property, not especially to add a Type constraint, as this constraint is a no-op for DateTimeInterface
|
Updated. |
fabpot
approved these changes
Sep 8, 2018
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Sep 8, 2018
…Date|Time|DateTime constraints (ro0NL) This PR was merged into the 4.2-dev branch. Discussion ---------- [Validator] Deprecate validating DateTimeInterface in Date|Time|DateTime constraints | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #11925 | License | MIT | Doc PR | symfony/symfony-docs#7583 (old PR but not really needed now) Easy version of #21905. I think individual naming has value. Also the goal is to move forward to use `Type` really, not to bother with constraint renames. Commits ------- 5454e6f [Validator] Deprecate validating DateTimeInterface in Date|Time|DateTime constraints
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 8, 2018
…dators (ro0NL) This PR was squashed before being merged into the master branch (closes #10302). Discussion ---------- Remove \DateTimeInterface reference from constraint validators See symfony/symfony#25015 Commits ------- 47b5917 Remove \DateTimeInterface reference from constraint validators
This was referenced Nov 3, 2018
Closed
Merged
nicolas-grekas
added a commit
that referenced
this pull request
May 29, 2019
…ors (ro0NL) This PR was merged into the 5.0-dev branch. Discussion ---------- [Validator] Remove DateTime support in date/time validators | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> See #25015 Commits ------- 37c1cbb [Validator] Remove DateTime support in date/time validators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy version of #21905. I think individual naming has value. Also the goal is to move forward to use
Typereally, not to bother with constraint renames.