[FrameworkBundle] Ignore failures when removing the old cache dir #25078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh, sorry I can't reproduce this anymore 'cause I fixed it by upgrading macos to beta |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 21, 2017
…cache dir (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Ignore failures when removing the old cache dir | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25066 | License | MIT | Doc PR | - ping @phoenixgao can you please check if this improves the situation? Commits ------- 3c4d168 [FrameworkBundle] Ignore failures when removing the old cache dir
|
Is there a reason why the same try-catch is not done here [1] as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @phoenixgao can you please check if this improves the situation?