Pr/workflow name as graph label #25148
Conversation
| @@ -37,6 +37,7 @@ protected function configure() | |||
| ->setDefinition(array( | |||
| new InputArgument('name', InputArgument::REQUIRED, 'A workflow name'), | |||
| new InputArgument('marking', InputArgument::IS_ARRAY, 'A marking (a list of places)'), | |||
| new InputOption('workflow-name-label', null, null, 'Labels graph with workflow name'), | |||
There was a problem hiding this comment.
what about --label | --label="value" api? Using workflow name as default value.
There was a problem hiding this comment.
Thx for your comment thats a very good idea. I will change it.
There was a problem hiding this comment.
I updated my pull request now it's like you suggested
|
Could you please rebase to fix the conflict ? |
| $options = array(); | ||
| $label = $input->getOption('label'); | ||
| if (null !== $label && '' !== trim($label)) { | ||
| $options = array('graph' => array('label' => $input->getOption('label'))); |
There was a problem hiding this comment.
You should be using $label instead of $input->getOption('label').
|
@shdev Can you rebase the pull request? You've merged master, but we don't merge pull requests with merge commits. I can help you do that if needed. Thanks. |
|
@fabpot Thx. It would be nice, if you give me some hints to do the rebase. Sorry for the merges, I did the changes on Github.com and I'm not familiar with rebasing there |
- Workflow Command labels a graph with workflow name if option is set
- [] -> array()
- Improvement from @ro0NL
- Fabbot.io suggestion
5468fa5 to
a7875ed
Compare
|
I don't think it's possible to rebase from the UI. I see that you did everything with the web UI, so I've just done the rebase for you. I've downloaded your code and did a |
|
Thank you @fabpot for the work, next time I use rebase |
a7875ed to
9d0dda3
Compare
|
Thank you @shdev. |
This PR was squashed before being merged into the 4.1-dev branch (closes #25148). Discussion ---------- Pr/workflow name as graph label | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This pull request added an option to the workflow dumper command, which allows you to add a graph label with the workflow name to the output. Without the option nothing changed the behavior from before. Example call: ```bash bin/console workflow:dump <workflowname> --label=custom_label ``` Commits ------- 0afce8d Pr/workflow name as graph label
This pull request added an option to the workflow dumper command, which allows you to add a graph label with the workflow name to the output. Without the option nothing changed the behavior from before.
Example call: