[DI] Remove unreachable code #25158
Merged
[DI] Remove unreachable code #25158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-grekas I am scratching my head on all the test fails here, they pass locally under the same PHP versions. Hints welcome 😄 |
|
What's the use case? Can't you use an iterator instead? The downside is that this would be a Symfony specific syntax, whereas I'm aiming at making this function a PSR, so that I'd prefer handling only things that might be accepted by the FIG... |
|
Zero stress, happy to close off. In that case, doesn't it make this dead code then: … as the regex will only allow |
correct! let's remove that :) |
|
No worries, I'll rebase and change direction 👍 |
| @@ -68,15 +68,12 @@ protected function processValue($value, $isRoot = false) | |||
| $declaringClass = (new \ReflectionMethod($class, 'getSubscribedServices'))->class; | |||
|
|
|||
| foreach ($class::getSubscribedServices() as $key => $type) { | |||
| if (!is_string($type) || !preg_match('/^\??[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*+(?:\\\\[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*+)*+$/', $type)) { | |||
| if (!is_string($type) || !preg_match('/^[\?!]?[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*+(?:\\\\[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*+)*+$/', $type)) { | |||
nicolas-grekas
approved these changes
Nov 26, 2017
xabbuh
approved these changes
Nov 26, 2017
fabpot
approved these changes
Nov 26, 2017
|
Thank you @GawainLynch. |
fabpot
added a commit
that referenced
this pull request
Nov 26, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [DI] Remove unreachable code | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | #24033 added the ability to ignore uninitialized references, but the regex above the conditional would lead to an `InvalidArgumentException` being thrown. Commits ------- ced0857 Remove unreachable code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24033 added the ability to ignore uninitialized references, but the regex above the conditional would lead to an
InvalidArgumentExceptionbeing thrown.